Remove ManagePasswordsUIController::NavigateToSmartLockPage

chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/passwords/manage_passwords_ui_controller.h"
 
 #include "base/auto_reset.h"
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/browsing_data/browsing_data_helper.h"
 #include "chrome/browser/password_manager/chrome_password_manager_client.h"
@@ skipping 292 matching lines @@
 #else
   chrome::NavigateParams params(
       chrome::FindBrowserWithWebContents(web_contents()),
       GURL(chrome::kPasswordManagerAccountDashboardURL),
       ui::PAGE_TRANSITION_LINK);
   params.disposition = NEW_FOREGROUND_TAB;
   chrome::Navigate(&params);
 #endif
 }
 
-void ManagePasswordsUIController::NavigateToSmartLockPage() {
-#if defined(OS_ANDROID)
-  NOTREACHED();
-#else
-  chrome::NavigateParams params(
-      chrome::FindBrowserWithWebContents(web_contents()),
-      GURL(l10n_util::GetStringUTF16(IDS_PASSWORD_MANAGER_SMART_LOCK_PAGE)),

[vasilii, 2015/11/23 10:25:21]

Why not changing the string in password_manager_infobar_delegate.cc? Then you
can make it android only.
Or you want to do it in a separate CL?

[vabr (Chromium), 2015/11/23 11:24:47]

Good point, keeping the link the same in the bubble and the infobars is a good
idea (I'll need to do the iOS part downstream, though).

I was almost tempted to remove also the last remaining use of
IDS_PASSWORD_MANAGER_SMART_LOCK_PAGE, in the Android account chooser, but I will
first double-check with Sabine, that the difference in the path does not matter
there. So let's keep that one for a follow-up CL. http://crbug.com/548259#c6

-      ui::PAGE_TRANSITION_LINK);
-  params.disposition = NEW_FOREGROUND_TAB;
-  chrome::Navigate(&params);
-#endif
-}
-
 void ManagePasswordsUIController::NavigateToSmartLockHelpPage() {
 #if defined(OS_ANDROID)
   NOTREACHED();
 #else
   chrome::NavigateParams params(
       chrome::FindBrowserWithWebContents(web_contents()),
       GURL(chrome::kSmartLockHelpPage), ui::PAGE_TRANSITION_LINK);
   params.disposition = NEW_FOREGROUND_TAB;
   chrome::Navigate(&params);
 #endif
@@ skipping 87 matching lines @@
   updater->ExecuteCommand(IDC_MANAGE_PASSWORDS_FOR_PAGE);
 #endif
 }
 
 void ManagePasswordsUIController::WebContentsDestroyed() {
   password_manager::PasswordStore* password_store =
       GetPasswordStore(web_contents());
   if (password_store)
     password_store->RemoveObserver(this);
 }