Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 1467973002: Inline Isolate::UncheckedCurrent into isolate.cc (Closed)

Created:
5 years, 1 month ago by jochen (gone - plz use gerrit)
Modified:
5 years, 1 month ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Inline Isolate::UncheckedCurrent into isolate.cc BUG=2487 R=yangguo@chromium.org LOG=n Committed: https://crrev.com/d9d603c556220421bd1c4daf5ec7af0e68a0cd35 Cr-Commit-Position: refs/heads/master@{#32165}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -9 lines) Patch
M src/isolate.h View 1 chunk +3 lines, -8 lines 0 comments Download
M src/isolate.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
jochen (gone - plz use gerrit)
5 years, 1 month ago (2015-11-23 07:53:48 UTC) #1
Yang
On 2015/11/23 07:53:48, jochen wrote: lgtm.
5 years, 1 month ago (2015-11-23 08:13:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1467973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1467973002/1
5 years, 1 month ago (2015-11-23 08:13:51 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-23 08:44:32 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 08:45:16 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d9d603c556220421bd1c4daf5ec7af0e68a0cd35
Cr-Commit-Position: refs/heads/master@{#32165}

Powered by Google App Engine
This is Rietveld 408576698