Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 1467923002: X87: Fix object initialization when slack tracking for it's map is still enabled. (Closed)

Created:
5 years, 1 month ago by zhengxing.li
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Fix object initialization when slack tracking for it's map is still enabled. port 2fc2cb99f52974d0743610189213a94585c30ac6 (r32144) original commit message: The old code was not ready for properly initialize objects with non standard headers and non zero in-object properties number. MacroAssembler::Allocate() implementations now return both start and end addresses of the new object (done by parameter renaming). BUG= Committed: https://crrev.com/d23330d49647d3b179c1213fe8fd95540f1b9fe4 Cr-Commit-Position: refs/heads/master@{#32161}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -21 lines) Patch
M src/x87/builtins-x87.cc View 1 chunk +4 lines, -10 lines 0 comments Download
M src/x87/macro-assembler-x87.h View 1 chunk +5 lines, -6 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
zhengxing.li
5 years, 1 month ago (2015-11-23 02:26:14 UTC) #2
Weiliang
lgtm
5 years, 1 month ago (2015-11-23 02:57:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1467923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1467923002/1
5 years, 1 month ago (2015-11-23 02:57:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-23 03:16:53 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 03:17:32 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d23330d49647d3b179c1213fe8fd95540f1b9fe4
Cr-Commit-Position: refs/heads/master@{#32161}

Powered by Google App Engine
This is Rietveld 408576698