Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: components/autofill/browser/webdata/autofill_webdata_service.cc

Issue 14679005: Create an AutofillBackend interface (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Clean up Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/browser/webdata/autofill_webdata_service.cc
diff --git a/components/autofill/browser/webdata/autofill_webdata_service.cc b/components/autofill/browser/webdata/autofill_webdata_service.cc
index 217f2651e9c105d7b24d829160564ef98e3b3521..09428a67592627a3f099939d73e14c22eac6fa25 100644
--- a/components/autofill/browser/webdata/autofill_webdata_service.cc
+++ b/components/autofill/browser/webdata/autofill_webdata_service.cc
@@ -37,26 +37,41 @@ void AutofillWebDataService::NotifyOfMultipleAutofillChanges(
make_scoped_refptr(web_data_service)));
}
+
Ilya Sherman 2013/05/07 00:02:43 nit: Spurious newline
Cait (Slow) 2013/05/07 19:22:07 Done.
AutofillWebDataService::AutofillWebDataService(
scoped_refptr<WebDatabaseService> wdbs,
const ProfileErrorCallback& callback)
: WebDataServiceBase(wdbs, callback),
+ weak_ptr_factory_(this),
autofill_backend_(new AutofillWebDataBackend()) {
}
AutofillWebDataService::AutofillWebDataService()
: WebDataServiceBase(NULL,
WebDataServiceBase::ProfileErrorCallback()),
+ weak_ptr_factory_(this),
autofill_backend_(new AutofillWebDataBackend()) {
}
void AutofillWebDataService::ShutdownOnUIThread() {
+ weak_ptr_factory_.InvalidateWeakPtrs();
BrowserThread::PostTask(
BrowserThread::DB, FROM_HERE,
base::Bind(&AutofillWebDataService::ShutdownOnDBThread, this));
WebDataServiceBase::ShutdownOnUIThread();
}
+void AutofillWebDataService::GetDelegateOnDB(
+ const DelegateOnDBCallback& del_callback) {
+ DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ base::Closure on_changed_callback = Bind(
+ &AutofillWebDataService::NotifyAutofillMultipleChangedOnUIThread,
+ weak_ptr_factory_.GetWeakPtr());
+ wdbs_->GetDatabaseOnDB(
+ Bind(&AutofillWebDataBackend::GetDelegate, autofill_backend_,
+ del_callback, on_changed_callback));
+}
+
void AutofillWebDataService::AddFormFields(
const std::vector<FormFieldData>& fields) {
wdbs_->ScheduleDBTask(FROM_HERE,
@@ -171,6 +186,7 @@ void AutofillWebDataService::RemoveObserver(
autofill_backend_->RemoveObserver(observer);
}
+
Jói 2013/05/06 23:08:39 spurious added blank line?
Cait (Slow) 2013/05/07 19:22:07 Done.
void AutofillWebDataService::AddObserver(
AutofillWebDataServiceObserverOnUIThread* observer) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

Powered by Google App Engine
This is Rietveld 408576698