Create an AutofillBackend interface

components/autofill/browser/webdata/autofill_webdata_backend.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/browser/webdata/autofill_webdata_backend.h"
 
 #include "base/logging.h"
 #include "base/stl_util.h"
 #include "components/autofill/browser/autofill_country.h"
 #include "components/autofill/browser/autofill_profile.h"
 #include "components/autofill/browser/credit_card.h"
 #include "components/autofill/browser/webdata/autofill_change.h"
 #include "components/autofill/browser/webdata/autofill_entry.h"
 #include "components/autofill/browser/webdata/autofill_table.h"
 #include "components/autofill/browser/webdata/autofill_webdata_service_observer.h"
 #include "components/autofill/common/form_field_data.h"
+#include "components/webdata/common/web_data_service_backend.h"
 
 using base::Bind;
 using base::Time;
 using content::BrowserThread;
 
 namespace autofill {
 
-AutofillWebDataBackend::AutofillWebDataBackend() {
+AutofillWebDataBackend::AutofillWebDataBackend(
+    scoped_refptr<WebDataServiceBackend> web_db_backend,
+    const base::Closure& on_changed_callback)
+    : web_database_backend_(web_db_backend),
+      on_changed_callback_(new base::Closure(on_changed_callback)) {
 }
 
 void AutofillWebDataBackend::AddObserver(
     AutofillWebDataServiceObserverOnDBThread* observer) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::DB));
   db_observer_list_.AddObserver(observer);
 }
 
 void AutofillWebDataBackend::RemoveObserver(
     AutofillWebDataServiceObserverOnDBThread* observer) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::DB));
   db_observer_list_.RemoveObserver(observer);
 }
 
-AutofillWebDataBackend::~AutofillWebDataBackend() {
+WebDatabase* AutofillWebDataBackend::GetDatabaseOnDB() {
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::DB));
+  if (!web_database_backend_)

[Ilya Sherman, 2013/05/08 00:39:06]

Why is it possible for web_database_backend_ to be NULL?

[Cait (Slow), 2013/05/08 19:16:01]

Done.

+    return NULL;
+
+  return web_database_backend_->database();
+}
+
+void AutofillWebDataBackend::RemoveExpiredFormElementsWrapper() {
+  if (!web_database_backend_ || !web_database_backend_->database())

[Ilya Sherman, 2013/05/08 00:39:06]

Why is it possible for web_database_backend_ or
web_database_backend_->database() to be NULL?

[Cait (Slow), 2013/05/08 19:16:01]

Done.

+    return;
+
+  if (RemoveExpiredFormElements(web_database_backend_->database()) ==
+      WebDatabase::COMMIT_NEEDED) {

[Ilya Sherman, 2013/05/08 00:39:06]

nit: Indent four more spaces.

[Cait (Slow), 2013/05/08 19:16:01]

Done.

+    web_database_backend_->database()->CommitTransaction();
+    web_database_backend_->database()->BeginTransaction();
+  }
+}
+
+void AutofillWebDataBackend::NotifyOfMultipleAutofillChanges() {
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::DB));
+
+  if (!on_changed_callback_.get()|| on_changed_callback_->is_null())

[Ilya Sherman, 2013/05/08 00:39:06]

nit: Please add a space before the "||" operator.

[Ilya Sherman, 2013/05/08 00:39:06]

Why is it possible for the callback to be null?

[Cait (Slow), 2013/05/08 19:16:01]

Done.

+    return;

[Ilya Sherman, 2013/05/08 00:39:06]

nit: Please leave a blank line after this one.

[Cait (Slow), 2013/05/08 19:16:01]

Done.

+  BrowserThread::PostTask(BrowserThread::UI,
+                          FROM_HERE,
+                          *(on_changed_callback_.get());

[Ilya Sherman, 2013/05/08 00:39:06]

This line looks like it's missing a parenthesis...

[Cait (Slow), 2013/05/08 19:16:01]

Done.

 }
 
 WebDatabase::State AutofillWebDataBackend::AddFormElements(
     const std::vector<FormFieldData>& fields, WebDatabase* db) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::DB));
   AutofillChangeList changes;
   if (!AutofillTable::FromWebDatabase(db)->AddFormFieldValues(
         fields, &changes)) {
     NOTREACHED();
     return WebDatabase::COMMIT_NOT_NEEDED;
@@ skipping 238 matching lines @@
                         db_observer_list_,
                         AutofillProfileChanged(change));
     }
     // Note: It is the caller's responsibility to post notifications for any
     // changes, e.g. by calling the Refresh() method of PersonalDataManager.
     return WebDatabase::COMMIT_NEEDED;
   }
   return WebDatabase::COMMIT_NOT_NEEDED;
 }
 
+AutofillWebDataBackend::~AutofillWebDataBackend() {
+}

[Ilya Sherman, 2013/05/08 00:39:06]

Hrm, why did this get moved down?

[Cait (Slow), 2013/05/08 19:16:01]

Done.

+
 void AutofillWebDataBackend::DestroyAutofillProfileResult(
     const WDTypedResult* result) {
   DCHECK(result->GetType() == AUTOFILL_PROFILES_RESULT);
   const WDResult<std::vector<AutofillProfile*> >* r =
       static_cast<const WDResult<std::vector<AutofillProfile*> >*>(result);
   std::vector<AutofillProfile*> profiles = r->GetValue();
   STLDeleteElements(&profiles);
 }
 
 void AutofillWebDataBackend::DestroyAutofillCreditCardResult(
       const WDTypedResult* result) {
   DCHECK(result->GetType() == AUTOFILL_CREDITCARDS_RESULT);
   const WDResult<std::vector<CreditCard*> >* r =
       static_cast<const WDResult<std::vector<CreditCard*> >*>(result);
 
   std::vector<CreditCard*> credit_cards = r->GetValue();
   STLDeleteElements(&credit_cards);
 }
 
 }  // namespace autofill