Issue 14679003: Add canvas blending modes behind a runtime flag

Issue 14679003: Add canvas blending modes behind a runtime flag (Closed)

Created:
7 years, 7 months ago by Rik

Modified:
7 years, 7 months ago

Reviewers:
Stephen Chennney, eseidel

CC:
blink-reviews, danakj, jamesr, Stephen Chennney, jeez

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Add canvas blending modes behind a runtime flag Refresh of https://codereview.chromium.org/13637006/ BUG=229111 TEST=fast/canvas/canvas-blend-* I duplicated issue https://codereview.chromium.org/13637006/ because Ion has no committer right and can't run his patch on the try bots Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150004

Patch Set 2 : updated check for RuntimeEnableFeatures #

Patch Set 3 : new patch for build failure #

Patch Set 5 : refreshed patch #

Total comments: 2

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -19 lines)			Patch
M	LayoutTests/fast/canvas/canvas-blend-image-expected.txt	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	LayoutTests/fast/canvas/canvas-blend-solid-expected.txt	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	LayoutTests/fast/canvas/script-tests/canvas-blend-image.js	View	1 2 3 4	2 chunks	+5 lines, -6 lines	0 comments	Download
M	LayoutTests/fast/canvas/script-tests/canvas-blend-solid.js	View	1 2 3 4	1 chunk	+2 lines, -2 lines	2 comments	Download
M	Source/core/html/canvas/CanvasRenderingContext2D.cpp	View	1 2 3	2 chunks	+3 lines, -0 lines	0 comments	Download
M	Source/core/platform/graphics/GraphicsContext.cpp	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/platform/graphics/GraphicsTypes.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/platform/graphics/skia/ImageBufferSkia.cpp	View	1 2 3 4	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/platform/graphics/skia/ImageSkia.cpp	View	1 2 3 4	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/platform/graphics/skia/SkiaUtils.h	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/platform/graphics/skia/SkiaUtils.cpp	View	1 2 3 4	1 chunk	+29 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

eseidel

lgtm This seems reasonable. https://codereview.chromium.org/14679003/diff/18001/LayoutTests/fast/canvas/script-tests/canvas-blend-solid.js File LayoutTests/fast/canvas/script-tests/canvas-blend-solid.js (right): https://codereview.chromium.org/14679003/diff/18001/LayoutTests/fast/canvas/script-tests/canvas-blend-solid.js#newcode72 LayoutTests/fast/canvas/script-tests/canvas-blend-solid.js:72: [[128, 0, 127, 255],[128, 128, ...

7 years, 7 months ago (2013-05-09 04:16:26 UTC) #2

Rik

https://codereview.chromium.org/14679003/diff/18001/LayoutTests/fast/canvas/script-tests/canvas-blend-solid.js File LayoutTests/fast/canvas/script-tests/canvas-blend-solid.js (right): https://codereview.chromium.org/14679003/diff/18001/LayoutTests/fast/canvas/script-tests/canvas-blend-solid.js#newcode72 LayoutTests/fast/canvas/script-tests/canvas-blend-solid.js:72: [[128, 0, 127, 255],[128, 128, 127, 255],[0, 64, 127, ...

7 years, 7 months ago (2013-05-09 04:19:25 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cabanier@adobe.com/14679003/18001

7 years, 7 months ago (2013-05-09 04:19:35 UTC) #4

Message was sent while issue was closed.

Change committed as 150004

Expand Messages | Collapse Messages