Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1083)

Issue 1467843002: top-level-ize gn's pkg_config in audio/BUILD.gn (Closed)

Created:
5 years, 1 month ago by rjkroege
Modified:
5 years, 1 month ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

top-level-ize gn's pkg_config in audio/BUILD.gn pkg_config can't be nested inside a source set. pull out in media/audio/BUILD.gn BUG=559487 Committed: https://crrev.com/cba97c506e4da5a8cba88ed8387c6165b4131df8 Cr-Commit-Position: refs/heads/master@{#361204}

Patch Set 1 #

Total comments: 1

Patch Set 2 : review nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M media/audio/BUILD.gn View 1 3 chunks +12 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
rjkroege
ptal
5 years, 1 month ago (2015-11-21 02:29:41 UTC) #2
Dirk Pranke
lgtm https://codereview.chromium.org/1467843002/diff/1/media/audio/BUILD.gn File media/audio/BUILD.gn (right): https://codereview.chromium.org/1467843002/diff/1/media/audio/BUILD.gn#newcode253 media/audio/BUILD.gn:253: if (link_pulseaudio) { nit: this could be just ...
5 years, 1 month ago (2015-11-21 02:43:14 UTC) #3
tommi (sloooow) - chröme
lgtm
5 years, 1 month ago (2015-11-21 14:09:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1467843002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1467843002/20001
5 years, 1 month ago (2015-11-23 21:42:01 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-23 22:27:05 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 22:28:12 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cba97c506e4da5a8cba88ed8387c6165b4131df8
Cr-Commit-Position: refs/heads/master@{#361204}

Powered by Google App Engine
This is Rietveld 408576698