Get 'gn_all' building on iOS

Get 'gn_all' building on iOS in GN builds.

This gets 'gn_all' building on iOS so we can start adding tryservers
to the CQ and turn on the waterfall bots.

At the moment WebRTC doesn't quite work on iOS, so we don't build
the components that need to depend on it; we add an 'ios_use_webrtc'
arg so that we can hack around it locally to build the rest of iOS,
but that arg should be deleted and WebRTC fixed.

R=sdefresne@chromium.org, brettw@chromium.org
BUG=459705, webrtc:5213
CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:ios_dbg_simulator_gn,ios_rel_device_gn

Committed: https://crrev.com/d43eab4836dbdb1e6a6f941c9359b121b685727b
Cr-Commit-Position: refs/heads/master@{#365373}

[Dirk Pranke, 2015-11-21 23:35:54]

Description was changed from

==========
Get 'gn_all' building on iOS

BUG=
==========

to

==========
Get 'gn_all' building on iOS in GN builds.

This gets 'gn_all' building on iOS so we can start adding tryservers
to the CQ and turn on the waterfall bots.

At the moment WebRTC doesn't quite work on iOS, so we don't build
the components that need to depend on it; we add an 'ios_use_webrtc'
arg so that we can hack around it locally to build the rest of iOS,
but that arg should be deleted and WebRTC fixed.

R=sdefresne@chromium.org, brettw@chromium.org
BUG=459705
==========

[Dirk Pranke, 2015-11-21 23:35:54]

dpranke@chromium.org changed reviewers:
+ brettw@chromium.org, sdefresne@chromium.org

[Dirk Pranke, 2015-11-21 23:36:57]

Description was changed from

==========
Get 'gn_all' building on iOS in GN builds.

This gets 'gn_all' building on iOS so we can start adding tryservers
to the CQ and turn on the waterfall bots.

At the moment WebRTC doesn't quite work on iOS, so we don't build
the components that need to depend on it; we add an 'ios_use_webrtc'
arg so that we can hack around it locally to build the rest of iOS,
but that arg should be deleted and WebRTC fixed.

R=sdefresne@chromium.org, brettw@chromium.org
BUG=459705
==========

to

==========
Get 'gn_all' building on iOS in GN builds.

This gets 'gn_all' building on iOS so we can start adding tryservers
to the CQ and turn on the waterfall bots.

At the moment WebRTC doesn't quite work on iOS, so we don't build
the components that need to depend on it; we add an 'ios_use_webrtc'
arg so that we can hack around it locally to build the rest of iOS,
but that arg should be deleted and WebRTC fixed.

R=sdefresne@chromium.org, brettw@chromium.org
BUG=459705, webrtc:5213
==========

[Dirk Pranke, 2015-11-22 00:53:20]

Please take a look. 

Ideally webrtc will be fixed quickly and we don't need to land the
ios_use_webrtc hack in any form, but I'd rather get *something* building as soon
as we can and this will at least allow us to get the bot son.

[Dirk Pranke, 2015-11-22 00:53:31]

The CQ bit was checked by dpranke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-22 00:53:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1467803003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1467803003/20001

[Dirk Pranke, 2015-11-22 00:54:10]

Description was changed from

==========
Get 'gn_all' building on iOS in GN builds.

This gets 'gn_all' building on iOS so we can start adding tryservers
to the CQ and turn on the waterfall bots.

At the moment WebRTC doesn't quite work on iOS, so we don't build
the components that need to depend on it; we add an 'ios_use_webrtc'
arg so that we can hack around it locally to build the rest of iOS,
but that arg should be deleted and WebRTC fixed.

R=sdefresne@chromium.org, brettw@chromium.org
BUG=459705, webrtc:5213
==========

to

==========
Get 'gn_all' building on iOS in GN builds.

This gets 'gn_all' building on iOS so we can start adding tryservers
to the CQ and turn on the waterfall bots.

At the moment WebRTC doesn't quite work on iOS, so we don't build
the components that need to depend on it; we add an 'ios_use_webrtc'
arg so that we can hack around it locally to build the rest of iOS,
but that arg should be deleted and WebRTC fixed.

R=sdefresne@chromium.org, brettw@chromium.org
BUG=459705, webrtc:5213
CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:ios_dbg_simulator_gn,ios_rel_device_gn
==========

[commit-bot: I haz the power, 2015-11-22 00:59:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-22 00:59:13]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[sdefresne, 2015-11-22 18:26:59]

lgtm

Thank you for taking care of this.

[Dirk Pranke, 2015-11-23 00:52:10]

Description was changed from

==========
Get 'gn_all' building on iOS in GN builds.

This gets 'gn_all' building on iOS so we can start adding tryservers
to the CQ and turn on the waterfall bots.

At the moment WebRTC doesn't quite work on iOS, so we don't build
the components that need to depend on it; we add an 'ios_use_webrtc'
arg so that we can hack around it locally to build the rest of iOS,
but that arg should be deleted and WebRTC fixed.

R=sdefresne@chromium.org, brettw@chromium.org
BUG=459705, webrtc:5213
CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:ios_dbg_simulator_gn,ios_rel_device_gn
==========

to

==========
Get 'gn_all' building on iOS in GN builds.

This gets 'gn_all' building on iOS so we can start adding tryservers
to the CQ and turn on the waterfall bots.

At the moment WebRTC doesn't quite work on iOS, so we don't build
the components that need to depend on it; we add an 'ios_use_webrtc'
arg so that we can hack around it locally to build the rest of iOS,
but that arg should be deleted and WebRTC fixed.

R=sdefresne@chromium.org
TBR=brettw@chromium.org
BUG=459705, webrtc:5213
CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:ios_dbg_simulator_gn,ios_rel_device_gn
==========

[Dirk Pranke, 2015-11-23 00:52:30]

Description was changed from

==========
Get 'gn_all' building on iOS in GN builds.

This gets 'gn_all' building on iOS so we can start adding tryservers
to the CQ and turn on the waterfall bots.

At the moment WebRTC doesn't quite work on iOS, so we don't build
the components that need to depend on it; we add an 'ios_use_webrtc'
arg so that we can hack around it locally to build the rest of iOS,
but that arg should be deleted and WebRTC fixed.

R=sdefresne@chromium.org
TBR=brettw@chromium.org
BUG=459705, webrtc:5213
CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:ios_dbg_simulator_gn,ios_rel_device_gn
==========

to

==========
Get 'gn_all' building on iOS in GN builds.

This gets 'gn_all' building on iOS so we can start adding tryservers
to the CQ and turn on the waterfall bots.

At the moment WebRTC doesn't quite work on iOS, so we don't build
the components that need to depend on it; we add an 'ios_use_webrtc'
arg so that we can hack around it locally to build the rest of iOS,
but that arg should be deleted and WebRTC fixed.

R=sdefresne@chromium.org, brettw@chromium.org
BUG=459705, webrtc:5213
CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:ios_dbg_simulator_gn,ios_rel_device_gn
==========

[Dirk Pranke, 2015-11-23 02:07:25]

The CQ bit was checked by dpranke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-23 02:07:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1467803003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1467803003/40001

[commit-bot: I haz the power, 2015-11-23 02:09:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-23 02:09:22]

Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)

[brettw, 2015-11-25 20:55:32]

lgtm

https://codereview.chromium.org/1467803003/diff/60001/build_overrides/webrtc.gni
File build_overrides/webrtc.gni (right):

https://codereview.chromium.org/1467803003/diff/60001/build_overrides/webrtc....
build_overrides/webrtc.gni:14: declare_args() {
Normally I put declare_args above other variables.

[Dirk Pranke, 2015-11-25 21:02:36]

https://codereview.chromium.org/1467803003/diff/60001/build_overrides/webrtc.gni
File build_overrides/webrtc.gni (right):

https://codereview.chromium.org/1467803003/diff/60001/build_overrides/webrtc....
build_overrides/webrtc.gni:14: declare_args() {
On 2015/11/25 20:55:32, brettw wrote:
> Normally I put declare_args above other variables.

fair enough.

[sdefresne, 2015-11-26 15:01:25]

Issue https://codereview.chromium.org/1477733003 removing the dependency on
webrtc on iOS landed today. I'll check whether this means that we can build
gn_all without this issue.

[sdefresne, 2015-11-26 15:22:22]

On 2015/11/26 at 15:01:25, sdefresne wrote:
> Issue https://codereview.chromium.org/1477733003 removing the dependency on
webrtc on iOS landed today. I'll check whether this means that we can build
gn_all without this issue.

Sadly, it still does not work because //components/invalidation/impl depends on
//jingle ...

[Dirk Pranke, 2015-12-15 21:39:21]

The CQ bit was checked by dpranke@chromium.org

[Dirk Pranke, 2015-12-15 21:39:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
sdefresne@chromium.org, brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/1467803003/#ps120001
(title: "fix ios arm build, non-ios build")

[commit-bot: I haz the power, 2015-12-15 21:40:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1467803003/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1467803003/120001

[commit-bot: I haz the power, 2015-12-15 23:11:04]

Description was changed from

==========
Get 'gn_all' building on iOS in GN builds.

This gets 'gn_all' building on iOS so we can start adding tryservers
to the CQ and turn on the waterfall bots.

At the moment WebRTC doesn't quite work on iOS, so we don't build
the components that need to depend on it; we add an 'ios_use_webrtc'
arg so that we can hack around it locally to build the rest of iOS,
but that arg should be deleted and WebRTC fixed.

R=sdefresne@chromium.org, brettw@chromium.org
BUG=459705, webrtc:5213
CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:ios_dbg_simulator_gn,ios_rel_device_gn
==========

to

==========
Get 'gn_all' building on iOS in GN builds.

This gets 'gn_all' building on iOS so we can start adding tryservers
to the CQ and turn on the waterfall bots.

At the moment WebRTC doesn't quite work on iOS, so we don't build
the components that need to depend on it; we add an 'ios_use_webrtc'
arg so that we can hack around it locally to build the rest of iOS,
but that arg should be deleted and WebRTC fixed.

R=sdefresne@chromium.org, brettw@chromium.org
BUG=459705, webrtc:5213
CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:ios_dbg_simulator_gn,ios_rel_device_gn
==========

[commit-bot: I haz the power, 2015-12-15 23:11:04]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2015-12-15 23:11:27]

Description was changed from

==========
Get 'gn_all' building on iOS in GN builds.

This gets 'gn_all' building on iOS so we can start adding tryservers
to the CQ and turn on the waterfall bots.

At the moment WebRTC doesn't quite work on iOS, so we don't build
the components that need to depend on it; we add an 'ios_use_webrtc'
arg so that we can hack around it locally to build the rest of iOS,
but that arg should be deleted and WebRTC fixed.

R=sdefresne@chromium.org, brettw@chromium.org
BUG=459705, webrtc:5213
CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:ios_dbg_simulator_gn,ios_rel_device_gn
==========

to

==========
Get 'gn_all' building on iOS in GN builds.

This gets 'gn_all' building on iOS so we can start adding tryservers
to the CQ and turn on the waterfall bots.

At the moment WebRTC doesn't quite work on iOS, so we don't build
the components that need to depend on it; we add an 'ios_use_webrtc'
arg so that we can hack around it locally to build the rest of iOS,
but that arg should be deleted and WebRTC fixed.

R=sdefresne@chromium.org, brettw@chromium.org
BUG=459705, webrtc:5213
CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:ios_dbg_simulator_gn,ios_rel_device_gn

Committed: https://crrev.com/d43eab4836dbdb1e6a6f941c9359b121b685727b
Cr-Commit-Position: refs/heads/master@{#365373}
==========

[commit-bot: I haz the power, 2015-12-15 23:11:28]

Patchset 7 (id:??) landed as
https://crrev.com/d43eab4836dbdb1e6a6f941c9359b121b685727b
Cr-Commit-Position: refs/heads/master@{#365373}