Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issue 14678003: Force linking with image decoders for images project. (Closed)

Created:
7 years, 7 months ago by scroggo
Modified:
7 years, 7 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Force linking with image decoders for images project. Previously, each tool that wanted to use image decoders but did not specifically reference them had to create a dummy function that references them in order to ensure they are not stripped by the linker. Instead of making each tool reference each image decoder, do it once in SkImageDecoder.cpp. Now each tool will have image decoders linked in, assuming it includes the images project. This fixes a bug where SKPs with encoded data could not be read by bench_ or render_pictures. R=djsollen@google.com, robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=8941

Patch Set 1 #

Patch Set 2 : Attach other decoders #

Patch Set 3 : Force linking image decoders with all tools #

Total comments: 2

Patch Set 4 : respond to comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -39 lines) Patch
M debugger/SkDebugger.cpp View 1 2 1 chunk +0 lines, -16 lines 0 comments Download
M gm/cmykjpeg.cpp View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M gyp/images.gyp View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M src/images/SkImageDecoder.cpp View 1 2 3 1 chunk +25 lines, -0 lines 0 comments Download
M tools/skimage_main.cpp View 1 2 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
scroggo
7 years, 7 months ago (2013-05-01 19:46:23 UTC) #1
djsollen
https://codereview.chromium.org/14678003/diff/4001/src/images/SkImageDecoder.cpp File src/images/SkImageDecoder.cpp (right): https://codereview.chromium.org/14678003/diff/4001/src/images/SkImageDecoder.cpp#newcode359 src/images/SkImageDecoder.cpp:359: #if !defined(SK_BUILD_FOR_WIN) && !defined(SK_BUILD_FOR_WIN) && !defined(SK_BUILD_FOR_NACL) SK_BUILD_FOR_WIN is duped ...
7 years, 7 months ago (2013-05-01 20:09:26 UTC) #2
scroggo
https://codereview.chromium.org/14678003/diff/4001/src/images/SkImageDecoder.cpp File src/images/SkImageDecoder.cpp (right): https://codereview.chromium.org/14678003/diff/4001/src/images/SkImageDecoder.cpp#newcode359 src/images/SkImageDecoder.cpp:359: #if !defined(SK_BUILD_FOR_WIN) && !defined(SK_BUILD_FOR_WIN) && !defined(SK_BUILD_FOR_NACL) On 2013/05/01 20:09:26, ...
7 years, 7 months ago (2013-05-01 20:13:04 UTC) #3
djsollen
lgtm
7 years, 7 months ago (2013-05-01 20:46:42 UTC) #4
robertphillips
lgtm
7 years, 7 months ago (2013-05-01 21:17:14 UTC) #5
scroggo
7 years, 7 months ago (2013-05-01 21:17:32 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 manually as r8941 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698