Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Issue 1467793002: Enable slimming paint synchronized painting (Closed)

Created:
5 years, 1 month ago by Xianzhu
Modified:
5 years ago
Reviewers:
chrishtr
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable slimming paint synchronized painting BUG=536999, 548528 Committed: https://crrev.com/c2fae545625e19ceed438e9850ec194d9574a9b2 Cr-Commit-Position: refs/heads/master@{#361570} Committed: https://crrev.com/68d76913c218a7abfb9f3db09681be489b447141 Cr-Commit-Position: refs/heads/master@{#361924}

Patch Set 1 #

Patch Set 2 : Rebase #

Messages

Total messages: 29 (11 generated)
Xianzhu
About the failing tests: - those about scrollbars will be fixed by https://codereview.chromium.org/1469823004/; - the ...
5 years ago (2015-11-23 19:53:30 UTC) #2
chrishtr
Looks like there are still two blocking bugs for issue 536999, will wait for those ...
5 years ago (2015-11-24 18:14:56 UTC) #3
Xianzhu
On 2015/11/24 18:14:56, chrishtr wrote: > Looks like there are still two blocking bugs for ...
5 years ago (2015-11-24 18:24:32 UTC) #4
chrishtr
Why are there any diffs needing rebaseline?
5 years ago (2015-11-24 18:56:15 UTC) #5
Xianzhu
On 2015/11/24 18:56:15, chrishtr wrote: > Why are there any diffs needing rebaseline? The expectation ...
5 years ago (2015-11-24 18:59:16 UTC) #6
chrishtr
lgtm
5 years ago (2015-11-24 19:03:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1467793002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1467793002/20001
5 years ago (2015-11-24 23:41:03 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/145710)
5 years ago (2015-11-25 01:30:48 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1467793002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1467793002/20001
5 years ago (2015-11-25 03:46:18 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-25 04:33:30 UTC) #15
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/c2fae545625e19ceed438e9850ec194d9574a9b2 Cr-Commit-Position: refs/heads/master@{#361570}
5 years ago (2015-11-25 04:34:28 UTC) #16
Sami
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1472243003/ by skyostil@chromium.org. ...
5 years ago (2015-11-25 13:48:30 UTC) #17
Xianzhu
The crash will be fixed by https://codereview.chromium.org/1477913002/.
5 years ago (2015-11-25 23:56:51 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1467793002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1467793002/20001
5 years ago (2015-11-26 01:10:58 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)
5 years ago (2015-11-26 03:39:04 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1467793002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1467793002/20001
5 years ago (2015-11-26 18:09:42 UTC) #25
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-26 21:15:08 UTC) #27
commit-bot: I haz the power
5 years ago (2015-11-26 21:16:19 UTC) #29
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/68d76913c218a7abfb9f3db09681be489b447141
Cr-Commit-Position: refs/heads/master@{#361924}

Powered by Google App Engine
This is Rietveld 408576698