LayoutTests/fast/css-grid-layout/percent-grid-item-in-percent-grid-track-update.html - Issue 146773002: [CSS Grid Layout] Rename grid-definition-{columns|rows} to match the new syntax

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/css-grid-layout/percent-grid-item-in-percent-grid-track-update.html

Issue 146773002: [CSS Grid Layout] Rename grid-definition-{columns|rows} to match the new syntax (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed renaming issues with some tests. Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/css-grid-layout/percent-grid-item-in-percent-grid-track-in-percent-grid.html ('k') | LayoutTests/fast/css-grid-layout/percent-padding-margin-resolution-grid-item.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/css-grid-layout/percent-grid-item-in-percent-grid-track-update.html

diff --git a/LayoutTests/fast/css-grid-layout/percent-grid-item-in-percent-grid-track-update.html b/LayoutTests/fast/css-grid-layout/percent-grid-item-in-percent-grid-track-update.html

index a53549f2c9d75d4802210790ac56302bd2e9adf7..81c237584a93059553e2c3acf6e3e37717906201 100644

--- a/LayoutTests/fast/css-grid-layout/percent-grid-item-in-percent-grid-track-update.html

+++ b/LayoutTests/fast/css-grid-layout/percent-grid-item-in-percent-grid-track-update.html

@@ -7,8 +7,8 @@ if (window.testRunner)

<style>

.grid {

- grid-definition-columns: 70% 30%;

- grid-definition-rows: 40% 60%;

+ grid-template-columns: 70% 30%;

+ grid-template-rows: 40% 60%;

width: 400px;

height: 300px;

}

@@ -41,12 +41,12 @@ function changeGridDefinitionsAndCheckValues()

var grid1 = document.getElementsByClassName("grid")[1];

var grid2 = document.getElementsByClassName("grid")[2];

document.body.offsetLeft;

- grid0.style.gridDefinitionColumns = "40% 60%";

+ grid0.style.gridTemplateColumns = "40% 60%";

- grid1.style.gridDefinitionRows = "30% 70%";

+ grid1.style.gridTemplateRows = "30% 70%";

- grid2.style.gridDefinitionColumns = "40% 60%";

- grid2.style.gridDefinitionRows = "30% 70%";

+ grid2.style.gridTemplateColumns = "40% 60%";

+ grid2.style.gridTemplateRows = "30% 70%";

checkLayout('.grid');

}