LayoutTests/fast/css-grid-layout/grid-item-with-percent-min-max-height-dynamic.html - Issue 146773002: [CSS Grid Layout] Rename grid-definition-{columns|rows} to match the new syntax

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/css-grid-layout/grid-item-with-percent-min-max-height-dynamic.html

Issue 146773002: [CSS Grid Layout] Rename grid-definition-{columns|rows} to match the new syntax (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed renaming issues with some tests. Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/css-grid-layout/grid-item-with-percent-height-in-auto-height-grid-resolution.html ('k') | LayoutTests/fast/css-grid-layout/grid-item-z-index-stacking-context.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/css-grid-layout/grid-item-with-percent-min-max-height-dynamic.html

diff --git a/LayoutTests/fast/css-grid-layout/grid-item-with-percent-min-max-height-dynamic.html b/LayoutTests/fast/css-grid-layout/grid-item-with-percent-min-max-height-dynamic.html

index 6095977daaa1517b0d98dbc38822fd6e0780a8de..4c22116857a0cdf9bd1576a3a28f3105d71b6a38 100644

--- a/LayoutTests/fast/css-grid-layout/grid-item-with-percent-min-max-height-dynamic.html

+++ b/LayoutTests/fast/css-grid-layout/grid-item-with-percent-min-max-height-dynamic.html

@@ -7,8 +7,8 @@ if (window.testRunner)

<style>

.grid {

- grid-definition-columns: 50px 100px;

- grid-definition-rows: 70px 140px;

+ grid-template-columns: 50px 100px;

+ grid-template-rows: 70px 140px;

}

#minHeightPercent {

@@ -26,7 +26,7 @@ if (window.testRunner)

function testLayout(gridElementID, gridTracks, size)

{

var gridElement = document.getElementById(gridElementID);

- gridElement.style.gridDefinitionRows = gridTracks.rows;

+ gridElement.style.gridTemplateRows = gridTracks.rows;

var gridItem = gridElement.firstChild.nextSibling;

gridItem.setAttribute("data-expected-width", size.width);

gridItem.setAttribute("data-expected-height", size.height);