LayoutTests/fast/css-grid-layout/grid-container-change-explicit-grid-recompute-child.html - Issue 146773002: [CSS Grid Layout] Rename grid-definition-{columns|rows} to match the new syntax

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/css-grid-layout/grid-container-change-explicit-grid-recompute-child.html

Issue 146773002: [CSS Grid Layout] Rename grid-definition-{columns|rows} to match the new syntax (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed renaming issues with some tests. Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt ('k') | LayoutTests/fast/css-grid-layout/grid-container-change-named-grid-lines-recompute-child.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/css-grid-layout/grid-container-change-explicit-grid-recompute-child.html

diff --git a/LayoutTests/fast/css-grid-layout/grid-container-change-explicit-grid-recompute-child.html b/LayoutTests/fast/css-grid-layout/grid-container-change-explicit-grid-recompute-child.html

index ff1d36dbc63d4c1dc0262160ba2237b1a31096f2..2ac159d5cf2be3cc5ad3a3ee8eef99502643fdab 100644

--- a/LayoutTests/fast/css-grid-layout/grid-container-change-explicit-grid-recompute-child.html

+++ b/LayoutTests/fast/css-grid-layout/grid-container-change-explicit-grid-recompute-child.html

@@ -26,11 +26,11 @@ if (window.testRunner)

}

</style>

-function testGridDefinitions(gridDefinitionRows, gridDefinitionColumns, firstGridItemData, secondGridItemData, thirdGridItemData)

+function testGridDefinitions(gridTemplateRows, gridTemplateColumns, firstGridItemData, secondGridItemData, thirdGridItemData)

{

var gridElement = document.getElementsByClassName("grid")[0];

- gridElement.style.gridDefinitionRows = gridDefinitionRows;

- gridElement.style.gridDefinitionColumns = gridDefinitionColumns;

+ gridElement.style.gridTemplateRows = gridTemplateRows;

+ gridElement.style.gridTemplateColumns = gridTemplateColumns;

var firstGridItem = document.getElementById("firstGridItem");

firstGridItem.setAttribute("data-expected-width", firstGridItemData.width);