LayoutTests/fast/css-grid-layout/minmax-min-content-column-resolution-rows.html - Issue 146773002: [CSS Grid Layout] Rename grid-definition-{columns|rows} to match the new syntax

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/css-grid-layout/minmax-min-content-column-resolution-rows.html

Issue 146773002: [CSS Grid Layout] Rename grid-definition-{columns|rows} to match the new syntax (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed renaming issues with some tests. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/css-grid-layout/minmax-min-content-column-resolution-columns.html ('k') | LayoutTests/fast/css-grid-layout/minmax-spanning-resolution-columns.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <script>	3 <script>

4 if (window.testRunner)	4 if (window.testRunner)

5 testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);	5 testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);

6 </script>	6 </script>

7 <link href="resources/grid.css" rel="stylesheet">	7 <link href="resources/grid.css" rel="stylesheet">

8 <style>	8 <style>

9 .gridMinMinContent {	9 .gridMinMinContent {

10 grid-definition-columns: 30px;	10 grid-template-columns: 30px;

11 grid-definition-rows: minmax(min-content, 40px);	11 grid-template-rows: minmax(min-content, 40px);

12 }	12 }

13	13

14 .gridMaxMinContent {	14 .gridMaxMinContent {

15 grid-definition-columns: 30px;	15 grid-template-columns: 30px;

16 grid-definition-rows: minmax(30px, min-content);	16 grid-template-rows: minmax(30px, min-content);

17 }	17 }

18	18

19 .firstRowFirstColumn {	19 .firstRowFirstColumn {

20 font: 10px/1 Ahem;	20 font: 10px/1 Ahem;

21 /* Make us fit our grid area. */	21 /* Make us fit our grid area. */

22 width: 100%;	22 width: 100%;

23 height: 100%;	23 height: 100%;

24 }	24 }

25 </style>	25 </style>

26 <script src="../../resources/check-layout.js"></script>	26 <script src="../../resources/check-layout.js"></script>

(...skipping 73 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
100	100

101 <div style="width: 30px; height: 100px">	101 <div style="width: 30px; height: 100px">

102 <div class="grid gridMaxMinContent">	102 <div class="grid gridMaxMinContent">

103 <!-- The 'max' logical width ends up being smaller than the 'min' so per the spec we ignore the 'max'. -->	103 <!-- The 'max' logical width ends up being smaller than the 'min' so per the spec we ignore the 'max'. -->

104 <div class="firstRowFirstColumn" data-expected-width="30" data-expected- height="30">XXX XXX</div>	104 <div class="firstRowFirstColumn" data-expected-width="30" data-expected- height="30">XXX XXX</div>

105 </div>	105 </div>

106 </div>	106 </div>

107	107

108 </body>	108 </body>

109 </html>	109 </html>

OLD	NEW