Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Side by Side Diff: LayoutTests/fast/css-grid-layout/minmax-fixed-logical-height-only.html

Issue 146773002: [CSS Grid Layout] Rename grid-definition-{columns|rows} to match the new syntax (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fixed renaming issues with some tests. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <html> 2 <html>
3 <script> 3 <script>
4 if (window.testRunner) 4 if (window.testRunner)
5 testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1); 5 testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
6 </script> 6 </script>
7 <link href="resources/grid.css" rel="stylesheet"> 7 <link href="resources/grid.css" rel="stylesheet">
8 <style> 8 <style>
9 .grid { 9 .grid {
10 width: 100px; 10 width: 100px;
11 height: 200px; 11 height: 200px;
12 } 12 }
13 13
14 #grid1 { 14 #grid1 {
15 grid-definition-columns: 30px; 15 grid-template-columns: 30px;
16 grid-definition-rows: minmax(20px, 80px) 160px; 16 grid-template-rows: minmax(20px, 80px) 160px;
17 } 17 }
18 18
19 #grid2 { 19 #grid2 {
20 grid-definition-columns: 30px; 20 grid-template-columns: 30px;
21 grid-definition-rows: minmax(50%, 120px) minmax(20px, 40%); 21 grid-template-rows: minmax(50%, 120px) minmax(20px, 40%);
22 } 22 }
23 23
24 #grid3 { 24 #grid3 {
25 grid-definition-columns: 30px; 25 grid-template-columns: 30px;
26 /* Overlapping range. */ 26 /* Overlapping range. */
27 grid-definition-rows: minmax(10px, 180px) minmax(30px, 150px); 27 grid-template-rows: minmax(10px, 180px) minmax(30px, 150px);
28 } 28 }
29 29
30 #grid4 { 30 #grid4 {
31 grid-definition-columns: 30px; 31 grid-template-columns: 30px;
32 grid-definition-rows: minmax(20px, 80px) 60px; 32 grid-template-rows: minmax(20px, 80px) 60px;
33 -webkit-writing-mode: vertical-rl; 33 -webkit-writing-mode: vertical-rl;
34 } 34 }
35 35
36 #grid5 { 36 #grid5 {
37 grid-definition-columns: 30px; 37 grid-template-columns: 30px;
38 /* 90% > 80px, 80px should be ignored. */ 38 /* 90% > 80px, 80px should be ignored. */
39 grid-definition-rows: minmax(90%, 80px) minmax(10px, 60%); 39 grid-template-rows: minmax(90%, 80px) minmax(10px, 60%);
40 -webkit-writing-mode: vertical-lr; 40 -webkit-writing-mode: vertical-lr;
41 } 41 }
42 42
43 #grid6 { 43 #grid6 {
44 /* Overlapping range. */ 44 /* Overlapping range. */
45 grid-definition-columns: 30px; 45 grid-template-columns: 30px;
46 grid-definition-rows: minmax(10px, 180px) minmax(30px, 150px); 46 grid-template-rows: minmax(10px, 180px) minmax(30px, 150px);
47 -webkit-writing-mode: horizontal-bt; 47 -webkit-writing-mode: horizontal-bt;
48 } 48 }
49 49
50 .firstRowFirstColumn { 50 .firstRowFirstColumn {
51 width: 100%; 51 width: 100%;
52 height: 100%; 52 height: 100%;
53 } 53 }
54 54
55 .secondRowFirstColumn { 55 .secondRowFirstColumn {
56 width: 100%; 56 width: 100%;
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 <div class="secondRowFirstColumn" data-expected-height="30" data-expected-wi dth="10"></div> 88 <div class="secondRowFirstColumn" data-expected-height="30" data-expected-wi dth="10"></div>
89 </div> 89 </div>
90 90
91 <div class="grid" id="grid6" data-expected-width="100" data-expected-height="200 "> 91 <div class="grid" id="grid6" data-expected-width="100" data-expected-height="200 ">
92 <div class="firstRowFirstColumn" data-expected-height="90" data-expected-wid th="30"></div> 92 <div class="firstRowFirstColumn" data-expected-height="90" data-expected-wid th="30"></div>
93 <div class="secondRowFirstColumn" data-expected-height="110" data-expected-w idth="30"></div> 93 <div class="secondRowFirstColumn" data-expected-height="110" data-expected-w idth="30"></div>
94 </div> 94 </div>
95 95
96 </body> 96 </body>
97 </html> 97 </html>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698