LayoutTests/fast/css-grid-layout/implicit-position-dynamic-change.html - Issue 146773002: [CSS Grid Layout] Rename grid-definition-{columns|rows} to match the new syntax

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/css-grid-layout/implicit-position-dynamic-change.html

Issue 146773002: [CSS Grid Layout] Rename grid-definition-{columns|rows} to match the new syntax (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed renaming issues with some tests. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/css-grid-layout/implicit-columns-auto-resolution.html ('k') | LayoutTests/fast/css-grid-layout/implicit-rows-auto-resolution.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <script>	3 <script>

4 if (window.testRunner)	4 if (window.testRunner)

5 testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);	5 testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);

6 </script>	6 </script>

7 <link href="resources/grid.css" rel="stylesheet">	7 <link href="resources/grid.css" rel="stylesheet">

8 <style>	8 <style>

9 .gridFixedContent {	9 .gridFixedContent {

10 grid-definition-columns: 50px minmax(min-content, 50px) minmax(max-content, 50px) minmax(50px, min-content);	10 grid-template-columns: 50px minmax(min-content, 50px) minmax(max-content, 50 px) minmax(50px, min-content);

11 grid-definition-rows: 70px minmax(max-content, 70px) minmax(50px, min-conten t) minmax(65px, max-content);	11 grid-template-rows: 70px minmax(max-content, 70px) minmax(50px, min-content) minmax(65px, max-content);

12 }	12 }

13 </style>	13 </style>

14 <script src="../../resources/check-layout.js"></script>	14 <script src="../../resources/check-layout.js"></script>

15 <script>	15 <script>

16 function testPosition(gridElementID, position, size)	16 function testPosition(gridElementID, position, size)

17 {	17 {

18 gridItem = document.getElementById(gridElementID).firstChild;	18 gridItem = document.getElementById(gridElementID).firstChild;

19 gridItem.style.gridColumn = position.column;	19 gridItem.style.gridColumn = position.column;

20 gridItem.style.gridRow = position.row;	20 gridItem.style.gridRow = position.row;

21 gridItem.setAttribute("data-expected-width", size.width);	21 gridItem.setAttribute("data-expected-width", size.width);

(...skipping 98 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
120 <div class="grid gridFixedContent" id="constrainedGridUndefinedHeight"><div class="sizedToGridArea">XXXX XXXX XXXX</div></div>	120 <div class="grid gridFixedContent" id="constrainedGridUndefinedHeight"><div class="sizedToGridArea">XXXX XXXX XXXX</div></div>

121 </div>	121 </div>

122	122

123 <!-- Allow the extra logical space distribution to occur. -->	123 <!-- Allow the extra logical space distribution to occur. -->

124 <div style="width: 1000px; height: 1000px">	124 <div style="width: 1000px; height: 1000px">

125 <div class="grid gridFixedContent" id="unconstrainedGrid"><div class="sizedT oGridArea">XXXXXX XXXXXX</div></div>	125 <div class="grid gridFixedContent" id="unconstrainedGrid"><div class="sizedT oGridArea">XXXXXX XXXXXX</div></div>

126 </div>	126 </div>

127	127

128 </body>	128 </body>

129 </html>	129 </html>

OLD	NEW