LayoutTests/fast/css-grid-layout/grid-item-position-changed-dynamic.html - Issue 146773002: [CSS Grid Layout] Rename grid-definition-{columns|rows} to match the new syntax

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/css-grid-layout/grid-item-position-changed-dynamic.html

Issue 146773002: [CSS Grid Layout] Rename grid-definition-{columns|rows} to match the new syntax (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed renaming issues with some tests. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/css-grid-layout/grid-item-order-paint-order.html ('k') | LayoutTests/fast/css-grid-layout/grid-item-removal-auto-placement-update.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <script>	3 <script>

4 if (window.testRunner)	4 if (window.testRunner)

5 testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);	5 testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);

6 </script>	6 </script>

7 <link href="resources/grid.css" rel="stylesheet">	7 <link href="resources/grid.css" rel="stylesheet">

8 <style>	8 <style>

9 .grid {	9 .grid {

10 grid-definition-columns: (col) 50px (col) 100px (col) 200px (col);	10 grid-template-columns: (col) 50px (col) 100px (col) 200px (col);

11 grid-definition-rows: (row) 70px (row) 140px (row) 280px (row);	11 grid-template-rows: (row) 70px (row) 140px (row) 280px (row);

12 }	12 }

13 .differentNamedGridLines {	13 .differentNamedGridLines {

14 grid-definition-columns: (col1) 50px (col2) 100px (col3) 200px (col4);	14 grid-template-columns: (col1) 50px (col2) 100px (col3) 200px (col4);

15 grid-definition-rows: (row1) 70px (row2) 140px (row3) 280px (row4);	15 grid-template-rows: (row1) 70px (row2) 140px (row3) 280px (row4);

16 }	16 }

17 </style>	17 </style>

18 <script src="../../resources/check-layout.js"></script>	18 <script src="../../resources/check-layout.js"></script>

19 <script>	19 <script>

20 function testPosition(position, size)	20 function testPosition(position, size)

21 {	21 {

22 gridItem = document.getElementsByClassName("grid")[0].firstChild;	22 gridItem = document.getElementsByClassName("grid")[0].firstChild;

23 gridItem.style.gridColumn = position.column;	23 gridItem.style.gridColumn = position.column;

24 gridItem.style.gridRow = position.row;	24 gridItem.style.gridRow = position.row;

25 gridItem.setAttribute("data-expected-width", size.width);	25 gridItem.setAttribute("data-expected-width", size.width);

(...skipping 155 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
181 window.addEventListener("load", updateGridItemPosition, false);	181 window.addEventListener("load", updateGridItemPosition, false);

182 </script>	182 </script>

183 <body>	183 <body>

184	184

185 <p>This test checks that we properly recompute our internal grid when a grid ite m is moved.</p>	185 <p>This test checks that we properly recompute our internal grid when a grid ite m is moved.</p>

186	186

187 <div class="grid"><div class="sizedToGridArea"></div></div>	187 <div class="grid"><div class="sizedToGridArea"></div></div>

188	188

189 </body>	189 </body>

190 </html>	190 </html>

OLD	NEW