LayoutTests/fast/css-grid-layout/grid-item-named-grid-line-resolution.html - Issue 146773002: [CSS Grid Layout] Rename grid-definition-{columns|rows} to match the new syntax

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/css-grid-layout/grid-item-named-grid-line-resolution.html

Issue 146773002: [CSS Grid Layout] Rename grid-definition-{columns|rows} to match the new syntax (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed renaming issues with some tests. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/css-grid-layout/grid-item-named-grid-area-resolution.html ('k') | LayoutTests/fast/css-grid-layout/grid-item-negative-integer-explicit-grid-resolution.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <script>	4 <script>

5 if (window.testRunner)	5 if (window.testRunner)

6 testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);	6 testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);

7 </script>	7 </script>

8 <link href="resources/grid.css" rel="stylesheet">	8 <link href="resources/grid.css" rel="stylesheet">

9 <style>	9 <style>

10 .gridWithoutRepeat {	10 .gridWithoutRepeat {

11 grid-definition-columns: (a) 50px (b) 100px (c) 200px (d);	11 grid-template-columns: (a) 50px (b) 100px (c) 200px (d);

12 grid-definition-rows: (e) 50px (f) 100px (g) 200px (h);	12 grid-template-rows: (e) 50px (f) 100px (g) 200px (h);

13 }	13 }

14	14

15 .gridWithRepeat {	15 .gridWithRepeat {

16 grid-definition-columns: (b) 50px (b) 100px (b) 200px (b);	16 grid-template-columns: (b) 50px (b) 100px (b) 200px (b);

17 grid-definition-rows: (g) 50px (g) 100px (g) 200px (g);	17 grid-template-rows: (g) 50px (g) 100px (g) 200px (g);

18 }	18 }

19	19

20 .gridItemBToD {	20 .gridItemBToD {

21 grid-column: 'b' / 'd';	21 grid-column: 'b' / 'd';

22 grid-row: 1;	22 grid-row: 1;

23 }	23 }

24	24

25 .gridItemGToH {	25 .gridItemGToH {

26 grid-column: 1;	26 grid-column: 1;

27 grid-row: 'g' / 'h';	27 grid-row: 'g' / 'h';

(...skipping 124 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
152 </div>	152 </div>

153	153

154 <div style="position: relative">	154 <div style="position: relative">

155 <div class="grid gridWithRepeat">	155 <div class="grid gridWithRepeat">

156 <div class="sizedToGridArea gridItemSpan2GNegativeG" data-offset-x="0" d ata-offset-y="50" data-expected-width="50" data-expected-height="300"></div>	156 <div class="sizedToGridArea gridItemSpan2GNegativeG" data-offset-x="0" d ata-offset-y="50" data-expected-width="50" data-expected-height="300"></div>

157 </div>	157 </div>

158 </div>	158 </div>

159	159

160 </body>	160 </body>

161 </html>	161 </html>

OLD	NEW