LayoutTests/fast/css-grid-layout/grid-dynamic-updates-relayout.html - Issue 146773002: [CSS Grid Layout] Rename grid-definition-{columns|rows} to match the new syntax

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/css-grid-layout/grid-dynamic-updates-relayout.html

Issue 146773002: [CSS Grid Layout] Rename grid-definition-{columns|rows} to match the new syntax (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed renaming issues with some tests. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/css-grid-layout/grid-container-change-named-grid-lines-recompute-child.html ('k') | LayoutTests/fast/css-grid-layout/grid-element-border-grid-item.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <script>	3 <script>

4 if (window.testRunner)	4 if (window.testRunner)

5 testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);	5 testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);

6 </script>	6 </script>

7 <link href="resources/grid.css" rel="stylesheet">	7 <link href="resources/grid.css" rel="stylesheet">

8 <script src="../../resources/check-layout.js"></script>	8 <script src="../../resources/check-layout.js"></script>

9 <script>	9 <script>

10 function testLayout(gridElementID, gridTracks, size)	10 function testLayout(gridElementID, gridTracks, size)

11 {	11 {

12 var gridElement = document.getElementById(gridElementID);	12 var gridElement = document.getElementById(gridElementID);

13 gridElement.style.gridDefinitionColumns = gridTracks.columns;	13 gridElement.style.gridTemplateColumns = gridTracks.columns;

14 gridElement.style.gridDefinitionRows = gridTracks.rows;	14 gridElement.style.gridTemplateRows = gridTracks.rows;

15 var gridItem = gridElement.firstChild.nextSibling;	15 var gridItem = gridElement.firstChild.nextSibling;

16 gridItem.setAttribute("data-expected-width", size.width);	16 gridItem.setAttribute("data-expected-width", size.width);

17 gridItem.setAttribute("data-expected-height", size.height);	17 gridItem.setAttribute("data-expected-height", size.height);

18 checkLayout("#" + gridElementID);	18 checkLayout("#" + gridElementID);

19 }	19 }

20	20

21 function updateRowsColumns()	21 function updateRowsColumns()

22 {	22 {

23 // In the constrained grid case, we will always end up sizing after the min width. This means we don't test max width changes as they would not be detectabl e.	23 // In the constrained grid case, we will always end up sizing after the min width. This means we don't test max width changes as they would not be detectabl e.

24 testLayout("constrainedGrid", { 'rows': 'minmax(20px, 50px)', 'columns': 'mi nmax(30px, 50px)' }, { 'width': '30', 'height': '20' });	24 testLayout("constrainedGrid", { 'rows': 'minmax(20px, 50px)', 'columns': 'mi nmax(30px, 50px)' }, { 'width': '30', 'height': '20' });

(...skipping 37 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
62 </div>	62 </div>

63 </div>	63 </div>

64	64

65 <div class="unconstrainedContainer">	65 <div class="unconstrainedContainer">

66 <div class="grid" id="unconstrainedGrid">	66 <div class="grid" id="unconstrainedGrid">

67 <div class="sizedToGridArea">XXXXX XXXXXX</div>	67 <div class="sizedToGridArea">XXXXX XXXXXX</div>

68 </div>	68 </div>

69 </div>	69 </div>

70 </body>	70 </body>

71 </html>	71 </html>

OLD	NEW