Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1467703003: Timeline: fix exception when updating tree view details and Events tree experiment is off (Closed)

Created:
5 years, 1 month ago by caseq
Modified:
5 years, 1 month ago
Reviewers:
alph, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Timeline: fix exception when updating tree view details and Events tree experiment is off BUG= Committed: https://crrev.com/84d17540958f558bb3b7df0ad3a48a7a219583b8 Cr-Commit-Position: refs/heads/master@{#361156}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
caseq
5 years, 1 month ago (2015-11-21 02:51:39 UTC) #2
alph
lgtm
5 years, 1 month ago (2015-11-23 17:39:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1467703003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1467703003/1
5 years, 1 month ago (2015-11-23 17:40:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-23 19:28:51 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 19:30:20 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/84d17540958f558bb3b7df0ad3a48a7a219583b8
Cr-Commit-Position: refs/heads/master@{#361156}

Powered by Google App Engine
This is Rietveld 408576698