Make Samba build with ARM. Currently may not work at runtime though.

Make Samba build with ARM. Currently may not work at runtime though.

This is just a slight cleanup/correction of https://codereview.chromium.org/1456633004

BUG=

Committed: https://chromium.googlesource.com/webports/+/5f337514440c9addbb029c6de4c8c749a3f4a722

[zentaro, 2015-11-20 21:24:26]

Description was changed from

==========
Make Samba build with ARM. Currently may not work at runtime though.

BUG=
==========

to

==========
Make Samba build with ARM. Currently may not work at runtime though.

BUG=
==========

[zentaro, 2015-11-20 21:24:26]

zentaro@chromium.org changed reviewers:
+ bradnelson@chromium.org, sbc@chromium.org

[zentaro, 2015-11-20 21:26:20]

Description was changed from

==========
Make Samba build with ARM. Currently may not work at runtime though.

BUG=
==========

to

==========
Make Samba build with ARM. Currently may not work at runtime though.

This is just a slight cleanup/correction of
https://codereview.chromium.org/1456633004

BUG=
==========

[Sam Clegg, 2015-12-11 23:24:49]

lgtm

https://codereview.chromium.org/1467623003/diff/1/ports/samba/build.sh
File ports/samba/build.sh (right):

https://codereview.chromium.org/1467623003/diff/1/ports/samba/build.sh#newcode14
ports/samba/build.sh:14:
NACLPORTS_LDFLAGS="${NACLPORTS_CPPFLAGS/-fdiagnostics-color=auto/}"
Is this really needed?

https://codereview.chromium.org/1467623003/diff/1/ports/samba/nacl.patch
File ports/samba/nacl.patch (right):

https://codereview.chromium.org/1467623003/diff/1/ports/samba/nacl.patch#newc...
ports/samba/nacl.patch:274: +	//des_not_rand_data(data, size);
Hmm, any idea why this is an arm only problem?

[zentaro, 2015-12-16 21:33:48]

On 2015/12/11 23:24:49, Sam Clegg wrote:
> lgtm
> 
> https://codereview.chromium.org/1467623003/diff/1/ports/samba/build.sh
> File ports/samba/build.sh (right):
> 
>
https://codereview.chromium.org/1467623003/diff/1/ports/samba/build.sh#newcode14
> ports/samba/build.sh:14:
> NACLPORTS_LDFLAGS="${NACLPORTS_CPPFLAGS/-fdiagnostics-color=auto/}"
> Is this really needed?

The diagnostics-color was causing compilation to fail. Not sure why only on ARM.

> 
> https://codereview.chromium.org/1467623003/diff/1/ports/samba/nacl.patch
> File ports/samba/nacl.patch (right):
> 
>
https://codereview.chromium.org/1467623003/diff/1/ports/samba/nacl.patch#newc...
> ports/samba/nacl.patch:274: +	//des_not_rand_data(data, size);
> Hmm, any idea why this is an arm only problem?

No. I assume some configure flag is on for ARM that isn't for x86. But I'm going
to send an email to Jeremy to ask him the implication of commenting out or more
context.

[Sam Clegg, 2015-12-16 21:45:15]

lgtm

[zentaro, 2015-12-16 21:48:32]

The CQ bit was checked by zentaro@chromium.org

[commit-bot: I haz the power, 2015-12-16 21:48:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1467623003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1467623003/20001

[commit-bot: I haz the power, 2015-12-17 01:48:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-17 01:48:02]

Try jobs failed on following builders:
  webports-linux-pnacl-1 on tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/webports-linux-pnacl-1/bu...)

[zentaro, 2015-12-17 22:07:11]

The CQ bit was checked by zentaro@chromium.org

[commit-bot: I haz the power, 2015-12-17 22:07:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1467623003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1467623003/20001

[commit-bot: I haz the power, 2015-12-17 22:13:12]

Description was changed from

==========
Make Samba build with ARM. Currently may not work at runtime though.

This is just a slight cleanup/correction of
https://codereview.chromium.org/1456633004

BUG=
==========

to

==========
Make Samba build with ARM. Currently may not work at runtime though.

This is just a slight cleanup/correction of
https://codereview.chromium.org/1456633004

BUG=

Committed:
https://chromium.googlesource.com/webports/+/5f337514440c9addbb029c6de4c8c749...
==========

[commit-bot: I haz the power, 2015-12-17 22:13:13]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/webports/+/5f337514440c9addbb029c6de4c8c749...