Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 1467623003: Make Samba build with ARM. Currently may not work at runtime though. (Closed)

Created:
5 years, 1 month ago by zentaro
Modified:
5 years ago
Reviewers:
bradnelson, Sam Clegg
CC:
native-client-reviews_googlegroups.com, Sam Clegg
Base URL:
https://chromium.googlesource.com/external/naclports.git@master
Target Ref:
refs/heads/master
Project:
webports
Visibility:
Public.

Description

Make Samba build with ARM. Currently may not work at runtime though. This is just a slight cleanup/correction of https://codereview.chromium.org/1456633004 BUG= Committed: https://chromium.googlesource.com/webports/+/5f337514440c9addbb029c6de4c8c749a3f4a722

Patch Set 1 #

Total comments: 2

Patch Set 2 : Re-upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -3 lines) Patch
M ports/samba/build.sh View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ports/samba/cc_shim.sh View 1 chunk +6 lines, -0 lines 0 comments Download
M ports/samba/nacl.patch View 1 2 chunks +26 lines, -0 lines 0 comments Download
M ports/samba/pkg_info View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Sam Clegg
lgtm https://codereview.chromium.org/1467623003/diff/1/ports/samba/build.sh File ports/samba/build.sh (right): https://codereview.chromium.org/1467623003/diff/1/ports/samba/build.sh#newcode14 ports/samba/build.sh:14: NACLPORTS_LDFLAGS="${NACLPORTS_CPPFLAGS/-fdiagnostics-color=auto/}" Is this really needed? https://codereview.chromium.org/1467623003/diff/1/ports/samba/nacl.patch File ports/samba/nacl.patch ...
5 years ago (2015-12-11 23:24:49 UTC) #4
zentaro
On 2015/12/11 23:24:49, Sam Clegg wrote: > lgtm > > https://codereview.chromium.org/1467623003/diff/1/ports/samba/build.sh > File ports/samba/build.sh (right): ...
5 years ago (2015-12-16 21:33:48 UTC) #5
Sam Clegg
lgtm
5 years ago (2015-12-16 21:45:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1467623003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1467623003/20001
5 years ago (2015-12-16 21:48:36 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: webports-linux-pnacl-1 on tryserver.nacl (JOB_FAILED, http://build.chromium.org/p/tryserver.nacl/builders/webports-linux-pnacl-1/builds/19)
5 years ago (2015-12-17 01:48:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1467623003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1467623003/20001
5 years ago (2015-12-17 22:07:23 UTC) #12
commit-bot: I haz the power
5 years ago (2015-12-17 22:13:13 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/webports/+/5f337514440c9addbb029c6de4c8c749...

Powered by Google App Engine
This is Rietveld 408576698