Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 1467623002: Fix test failures on the bots (Closed)

Created:
5 years, 1 month ago by Brian Wilkerson
Modified:
5 years, 1 month ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -47 lines) Patch
M pkg/analysis_server/test/abstract_context.dart View 2 chunks +3 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/analysis_abstract.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/analysis_server_test.dart View 2 chunks +4 lines, -1 line 0 comments Download
M pkg/analysis_server/test/context_manager_test.dart View 4 chunks +48 lines, -45 lines 0 comments Download
M pkg/analysis_server/test/domain_diagnostic_test.dart View 2 chunks +5 lines, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/optype_test.dart View 2 chunks +6 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/context/abstract_context.dart View 2 chunks +3 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/strong_test_helper.dart View 2 chunks +4 lines, -0 lines 0 comments Download
M pkg/analyzer/tool/task_dependency_graph/generate.dart View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Brian Wilkerson
This adds a lot of duplication, which I hope to clean up later, but I ...
5 years, 1 month ago (2015-11-20 19:45:30 UTC) #2
scheglov
LGTM
5 years, 1 month ago (2015-11-20 19:46:22 UTC) #3
Brian Wilkerson
5 years, 1 month ago (2015-11-20 19:48:39 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6b45d6544cdf3cf0a3f7b0dbacd87521ed91b80a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698