Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: Source/bindings/scripts/CodeGeneratorV8.pm

Issue 14676023: Remove DOM prefix from plugins IDL interfaces (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix build due to (unrelated) missing include in generated code Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/core.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/CodeGeneratorV8.pm
diff --git a/Source/bindings/scripts/CodeGeneratorV8.pm b/Source/bindings/scripts/CodeGeneratorV8.pm
index 62f3a527ffdce152e55b8252ade8654b6c938c11..83972b3409bf383259fba5fbc02589b996e6cdf9 100644
--- a/Source/bindings/scripts/CodeGeneratorV8.pm
+++ b/Source/bindings/scripts/CodeGeneratorV8.pm
@@ -498,7 +498,11 @@ END
my $methodName;
$methodName = "document" if (GetGenerateIsReachable($interface) eq "ImplDocument");
- $methodName = "element" if (GetGenerateIsReachable($interface) eq "ImplElementRoot");
+ if (GetGenerateIsReachable($interface) eq "ImplElementRoot") {
+ $methodName = "element";
+ # Include Element.h so that the implicit cast from Element* to Node* compiles.
+ AddToImplIncludes("core/dom/Element.h");
do-not-use 2013/05/16 22:38:21 I was getting the following error locally without
+ }
$methodName = "owner" if (GetGenerateIsReachable($interface) eq "ImplOwnerRoot");
$methodName = "ownerNode" if (GetGenerateIsReachable($interface) eq "ImplOwnerNodeRoot");
« no previous file with comments | « no previous file | Source/core/core.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698