Issue 14676023: Remove DOM prefix from plugins IDL interfaces

Issue 14676023: Remove DOM prefix from plugins IDL interfaces (Closed)

Created:
7 years, 7 months ago by do-not-use

Modified:
7 years, 7 months ago

Reviewers:
haraken, arv (Not doing code reviews), abarth-chromium

CC:
blink-reviews, eae+blinkwatch, lgombos

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove DOM prefix from plugins IDL interfaces Remove DOM prefix from plugins IDL interfaces and use [ImplementedAs] extended attribute instead of the now deprecated [InterfaceName]. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150551

Patch Set 1 #

Patch Set 2 : Fix build due to (unrelated) missing include in generated code #

Total comments: 1

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -139 lines)			Patch
M	Source/bindings/scripts/CodeGeneratorV8.pm	View	1	1 chunk	+5 lines, -1 line	1 comment	Download
M	Source/core/core.gypi	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
M	Source/core/page/Navigator.idl	View		1 chunk	+2 lines, -2 lines	0 comments	Download
D	Source/core/plugins/DOMMimeType.idl	View		1 chunk	+0 lines, -29 lines	0 comments	Download
D	Source/core/plugins/DOMMimeTypeArray.idl	View		1 chunk	+0 lines, -28 lines	0 comments	Download
D	Source/core/plugins/DOMPlugin.idl	View		1 chunk	+0 lines, -31 lines	0 comments	Download
D	Source/core/plugins/DOMPluginArray.idl	View		1 chunk	+0 lines, -29 lines	0 comments	Download
A +	Source/core/plugins/MimeType.idl	View		1 chunk	+3 lines, -3 lines	0 comments	Download
A +	Source/core/plugins/MimeTypeArray.idl	View		1 chunk	+4 lines, -4 lines	0 comments	Download
A +	Source/core/plugins/Plugin.idl	View		1 chunk	+4 lines, -4 lines	0 comments	Download
A +	Source/core/plugins/PluginArray.idl	View		1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

do-not-use

https://codereview.chromium.org/14676023/diff/3001/Source/bindings/scripts/CodeGeneratorV8.pm File Source/bindings/scripts/CodeGeneratorV8.pm (right): https://codereview.chromium.org/14676023/diff/3001/Source/bindings/scripts/CodeGeneratorV8.pm#newcode504 Source/bindings/scripts/CodeGeneratorV8.pm:504: AddToImplIncludes("core/dom/Element.h"); I was getting the following error locally without ...

7 years, 7 months ago (2013-05-16 22:38:21 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/14676023/3001

7 years, 7 months ago (2013-05-17 06:29:06 UTC) #4

Message was sent while issue was closed.

Change committed as 150551

Expand Messages | Collapse Messages