PushMessagingNotificationManager: extract IsTabVisible and test it.

PushMessagingNotificationManager: extract IsTabVisible and test it.

BUG=558402
Committed: https://crrev.com/0035b7afee53c10d63aa4377800bb4d6ec65da04
Cr-Commit-Position: refs/heads/master@{#361101}

[Michael van Ouwerkerk, 2015-11-20 19:00:26]

mvanouwerkerk@chromium.org changed reviewers:
+ peter@chromium.org

[Michael van Ouwerkerk, 2015-11-20 19:00:26]

Peter, could you take a look please?

[Peter Beverloo, 2015-11-23 13:14:25]

tests! lgtm

https://codereview.chromium.org/1467573003/diff/1/chrome/browser/push_messagi...
File chrome/browser/push_messaging/push_messaging_notification_manager.cc
(right):

https://codereview.chromium.org/1467573003/diff/1/chrome/browser/push_messagi...
chrome/browser/push_messaging/push_messaging_notification_manager.cc:222: //
Ignore minimized windows etc.
nit: get rid of "etc" while you're at it? :)

https://codereview.chromium.org/1467573003/diff/1/chrome/browser/push_messagi...
File
chrome/browser/push_messaging/push_messaging_notification_manager_unittest.cc
(right):

https://codereview.chromium.org/1467573003/diff/1/chrome/browser/push_messagi...
chrome/browser/push_messaging/push_messaging_notification_manager_unittest.cc:10:
#include "testing/gtest/include/gtest/gtest.h"
+url/gurl.h

[Michael van Ouwerkerk, 2015-11-23 13:25:10]

https://codereview.chromium.org/1467573003/diff/1/chrome/browser/push_messagi...
File chrome/browser/push_messaging/push_messaging_notification_manager.cc
(right):

https://codereview.chromium.org/1467573003/diff/1/chrome/browser/push_messagi...
chrome/browser/push_messaging/push_messaging_notification_manager.cc:222: //
Ignore minimized windows etc.
On 2015/11/23 13:14:25, Peter Beverloo wrote:
> nit: get rid of "etc" while you're at it? :)

Done.

https://codereview.chromium.org/1467573003/diff/1/chrome/browser/push_messagi...
File
chrome/browser/push_messaging/push_messaging_notification_manager_unittest.cc
(right):

https://codereview.chromium.org/1467573003/diff/1/chrome/browser/push_messagi...
chrome/browser/push_messaging/push_messaging_notification_manager_unittest.cc:10:
#include "testing/gtest/include/gtest/gtest.h"
On 2015/11/23 13:14:25, Peter Beverloo wrote:
> +url/gurl.h

Done.

[Michael van Ouwerkerk, 2015-11-23 13:25:13]

The CQ bit was checked by mvanouwerkerk@chromium.org

[Michael van Ouwerkerk, 2015-11-23 13:25:13]

The patchset sent to the CQ was uploaded after l-g-t-m from peter@chromium.org
Link to the patchset: https://codereview.chromium.org/1467573003/#ps20001
(title: "Address peter's comments.")

[commit-bot: I haz the power, 2015-11-23 13:25:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1467573003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1467573003/20001

[commit-bot: I haz the power, 2015-11-23 14:29:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-23 14:29:03]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Peter Beverloo, 2015-11-23 14:29:23]

The CQ bit was checked by peter@chromium.org

[commit-bot: I haz the power, 2015-11-23 14:29:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1467573003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1467573003/20001

[commit-bot: I haz the power, 2015-11-23 15:07:49]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-23 15:09:08]

Patchset 2 (id:??) landed as
https://crrev.com/0035b7afee53c10d63aa4377800bb4d6ec65da04
Cr-Commit-Position: refs/heads/master@{#361101}