content/browser/loader/resource_request_info_impl.cc - Issue 1467563002: Use ResourceRequestInfo::GetWebContents in DownloadRequestLimiter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/loader/resource_request_info_impl.cc

Issue 1467563002: Use ResourceRequestInfo::GetWebContents in DownloadRequestLimiter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@web-contents-callback

Patch Set: Addressed davidben's comments Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/loader/resource_request_info_impl.h ('k') | content/public/browser/android/download_controller_android.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/loader/resource_request_info_impl.cc

diff --git a/content/browser/loader/resource_request_info_impl.cc b/content/browser/loader/resource_request_info_impl.cc

index 990ac79c90273b1f33bc251cf30aef27a94f0faa..c2d4477f4f8a10451351a76b6c803e470bd2fbe0 100644

--- a/content/browser/loader/resource_request_info_impl.cc

+++ b/content/browser/loader/resource_request_info_impl.cc

@@ -187,8 +187,8 @@ ResourceRequestInfoImpl::ResourceRequestInfoImpl(

ResourceRequestInfoImpl::~ResourceRequestInfoImpl() {

}

-base::Callback<WebContents*(void)>

-ResourceRequestInfoImpl::GetWebContentsForRequest() const {

+ResourceRequestInfo::WebContentsGetter

+ResourceRequestInfoImpl::GetWebContentsGetterForRequest() const {

// PlzNavigate: navigation requests are created with a valid FrameTreeNode ID

// and invalid RenderProcessHost and RenderFrameHost IDs. The FrameTreeNode

// ID should be used to access the WebContents.