chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc - Issue 1467563002: Use ResourceRequestInfo::GetWebContents in DownloadRequestLimiter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc

Issue 1467563002: Use ResourceRequestInfo::GetWebContents in DownloadRequestLimiter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@web-contents-callback

Patch Set: Addressed davidben's comments Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/download/download_resource_throttle_unittest.cc ('k') | content/browser/android/download_controller_android_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc

diff --git a/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc b/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc

index f10dfc30079d1c56ec8774c33f763aeaa1fba531..351d35a985508162f152020cee1f22be9fe04bae 100644

--- a/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc

+++ b/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc

@@ -419,9 +419,11 @@ void ChromeResourceDispatcherHostDelegate::DownloadStarting(

// If it's from the web, we don't trust it, so we push the throttle on.

if (is_content_initiated) {

+ const content::ResourceRequestInfo* info =

+ content::ResourceRequestInfo::ForRequest(request);

throttles->push_back(new DownloadResourceThrottle(

- download_request_limiter_, child_id, route_id, request->url(),

- request->method()));

+ download_request_limiter_, info->GetWebContentsGetterForRequest(),

+ request->url(), request->method()));

#if defined(OS_ANDROID)

throttles->push_back(

new chrome::InterceptDownloadResourceThrottle(