Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(722)

Unified Diff: content/browser/loader/resource_request_info_impl.h

Issue 1467563002: Use ResourceRequestInfo::GetWebContents in DownloadRequestLimiter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@web-contents-callback
Patch Set: Addressed Asanka's comments Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/resource_request_info_impl.h
diff --git a/content/browser/loader/resource_request_info_impl.h b/content/browser/loader/resource_request_info_impl.h
index db1f0a6961f2a286d1c25f55e5f806c2496d2704..2a3a292a4cca05a5fd93f7d62616dadeffa7e825 100644
--- a/content/browser/loader/resource_request_info_impl.h
+++ b/content/browser/loader/resource_request_info_impl.h
@@ -23,7 +23,6 @@ class CrossSiteResourceHandler;
class DetachableResourceHandler;
class ResourceContext;
class ResourceMessageFilter;
-class WebContents;
struct GlobalRequestID;
struct GlobalRoutingID;
@@ -71,6 +70,8 @@ class ResourceRequestInfoImpl : public ResourceRequestInfo,
~ResourceRequestInfoImpl() override;
// ResourceRequestInfo implementation:
+ base::Callback<WebContents*(void)> GetWebContentsGetterForRequest()
davidben 2015/12/01 22:15:15 Nit: I suppose if we're using a typedef, this shou
clamy 2015/12/02 09:34:00 Done.
+ const override;
ResourceContext* GetContext() const override;
int GetChildID() const override;
int GetRouteID() const override;
@@ -93,14 +94,6 @@ class ResourceRequestInfoImpl : public ResourceRequestInfo,
bool IsUsingLoFi() const override;
bool ShouldReportRawHeaders() const;
- // Returns a callback that returns a pointer to the WebContents this request
- // is associated with, or nullptr if it no longer exists or the request is
- // not associated with a WebContents. The callback should only run on the UI
- // thread.
- // Note: Not all resource requests will be owned by a WebContents. For
- // example, requests made by a ServiceWorker.
- base::Callback<WebContents*(void)> GetWebContentsForRequest() const;
-
CONTENT_EXPORT void AssociateWithRequest(net::URLRequest* request);
CONTENT_EXPORT int GetRequestID() const;

Powered by Google App Engine
This is Rietveld 408576698