chrome/browser/download/download_resource_throttle_unittest.cc - Issue 1467563002: Use ResourceRequestInfo::GetWebContents in DownloadRequestLimiter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_resource_throttle_unittest.cc

Issue 1467563002: Use ResourceRequestInfo::GetWebContents in DownloadRequestLimiter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@web-contents-callback

Patch Set: Addressed comments Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/download/download_resource_throttle.cc ('K') | « chrome/browser/download/download_resource_throttle.cc ('k') | chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc » ('j') | content/public/browser/resource_request_info.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/download/download_resource_throttle_unittest.cc

diff --git a/chrome/browser/download/download_resource_throttle_unittest.cc b/chrome/browser/download/download_resource_throttle_unittest.cc

index 20ac74d7c6085d57679200aef375310a25695ed6..dd4365d49007853f263123ec16437691f687c813 100644

--- a/chrome/browser/download/download_resource_throttle_unittest.cc

+++ b/chrome/browser/download/download_resource_throttle_unittest.cc

@@ -6,6 +6,7 @@

#include "base/run_loop.h"

#include "chrome/browser/download/download_request_limiter.h"

#include "chrome/browser/download/download_resource_throttle.h"

+#include "chrome/browser/tab_contents/tab_util.h"

#include "chrome/test/base/chrome_render_view_host_test_harness.h"

#include "content/public/browser/browser_thread.h"

#include "content/public/browser/render_process_host.h"

@@ -78,7 +79,9 @@ class DownloadResourceThrottleTest : public ChromeRenderViewHostTestHarness {

void StartThrottleOnIOThread(int process_id, int render_view_id) {

throttle_ = new DownloadResourceThrottle(

- limiter_, process_id, render_view_id, GURL(kTestUrl), "GET");

+ limiter_,

+ base::Bind(&tab_util::GetWebContentsByID, process_id, render_view_id),

+ GURL(kTestUrl), "GET");

throttle_->set_controller_for_testing(&resource_controller_);

bool defer;

throttle_->WillStartRequest(&defer);