Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1160)

Unified Diff: chrome/browser/download/download_request_limiter.h

Issue 1467563002: Use ResourceRequestInfo::GetWebContents in DownloadRequestLimiter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@web-contents-callback
Patch Set: Addressed comments Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/download_request_limiter.h
diff --git a/chrome/browser/download/download_request_limiter.h b/chrome/browser/download/download_request_limiter.h
index 50ea982aa3adc519927d826ed870d3fdb405391b..f2f085a88cb15441a99af669760ff82ccd76fce0 100644
--- a/chrome/browser/download/download_request_limiter.h
+++ b/chrome/browser/download/download_request_limiter.h
@@ -16,6 +16,7 @@
#include "components/content_settings/core/common/content_settings.h"
#include "content/public/browser/notification_observer.h"
#include "content/public/browser/notification_registrar.h"
+#include "content/public/browser/resource_request_info.h"
#include "content/public/browser/web_contents_observer.h"
class HostContentSettingsMap;
@@ -182,11 +183,12 @@ class DownloadRequestLimiter
DownloadStatus GetDownloadStatus(content::WebContents* tab);
// Check if download can proceed and notifies the callback on UI thread.
- void CanDownload(int render_process_host_id,
- int render_view_id,
- const GURL& url,
- const std::string& request_method,
- const Callback& callback);
+ void CanDownload(
+ const content::ResourceRequestInfo::WebContentsGetterOnUIThread&
+ web_contents_getter,
+ const GURL& url,
+ const std::string& request_method,
+ const Callback& callback);
private:
FRIEND_TEST_ALL_PREFIXES(DownloadTest, DownloadResourceThrottleCancels);
@@ -215,11 +217,12 @@ class DownloadRequestLimiter
const Callback& callback);
// Invoked when decision to download has been made.
- void OnCanDownloadDecided(int render_process_host_id,
- int render_view_id,
- const std::string& request_method,
- const Callback& orig_callback,
- bool allow);
+ void OnCanDownloadDecided(
+ const content::ResourceRequestInfo::WebContentsGetterOnUIThread&
+ web_contents_getter,
+ const std::string& request_method,
+ const Callback& orig_callback,
+ bool allow);
// Removes the specified TabDownloadState from the internal map and deletes
// it. This has the effect of resetting the status for the tab to

Powered by Google App Engine
This is Rietveld 408576698