Use ResourceRequestInfo::GetWebContents in DownloadRequestLimiter

content/public/browser/resource_request_info.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_RESOURCE_REQUEST_INFO_H_
 #define CONTENT_PUBLIC_BROWSER_RESOURCE_REQUEST_INFO_H_
 
 #include "base/basictypes.h"
+#include "base/callback_forward.h"
 #include "content/common/content_export.h"
 #include "content/public/common/resource_type.h"
 #include "third_party/WebKit/public/platform/WebPageVisibilityState.h"
 #include "third_party/WebKit/public/platform/WebReferrerPolicy.h"
 #include "ui/base/page_transition_types.h"
 
 namespace net {
 class URLRequest;
 }
 
 namespace content {
 class ResourceContext;
+class WebContents;
 
 // Each URLRequest allocated by the ResourceDispatcherHost has a
 // ResourceRequestInfo instance associated with it.
 class ResourceRequestInfo {
  public:
   // Returns the ResourceRequestInfo associated with the given URLRequest.
   CONTENT_EXPORT static const ResourceRequestInfo* ForRequest(
       const net::URLRequest* request);
 
   // Allocates a new, dummy ResourceRequestInfo and associates it with the
@@ skipping 13 matching lines @@
 
   // Returns the associated RenderFrame for a given process. Returns false, if
   // there is no associated RenderFrame. This method does not rely on the
   // request being allocated by the ResourceDispatcherHost, but works for all
   // URLRequests that are associated with a RenderFrame.
   CONTENT_EXPORT static bool GetRenderFrameForRequest(
       const net::URLRequest* request,
       int* render_process_id,
       int* render_frame_id);
 
+  // A callback that returns a pointer to a WebContents. The callback can
+  // always be used, but it may return nullptr : if the info used to

[asanka, 2015/11/25 19:33:02]

Nit: stray ':'

[clamy, 2015/11/27 13:29:06]

Done.

+  // instantiate the callback can no longer be used to return a WebContents,
+  // nullptr will be returned instead.
+  // The callback should only run on the UI thread and it should always be
+  // non-null.
+  using WebContentsGetterOnUIThread = base::Callback<WebContents*(void)>;

[asanka, 2015/11/25 19:33:02]

Nit: WebContentsGetter should also be sufficient since the thread restriction is
mentioned here.

[clamy, 2015/11/27 13:29:06]

Done.

+
+  // Returns a callback that returns a pointer to the WebContents this request
+  // is associated with, or nullptr if it no longer exists or the request is
+  // not associated with a WebContents. The callback should only run on the UI
+  // thread.
+  // Note: Not all resource requests will be owned by a WebContents. For
+  // example, requests made by a ServiceWorker.
+  virtual WebContentsGetterOnUIThread GetWebContentsGetterForRequest()

[asanka, 2015/11/25 19:33:02]

Nit: GetWebContentsGetter is also sufficient.

[clamy, 2015/11/27 13:29:06]

Done.

+      const = 0;
+
   // Returns the associated ResourceContext.
   virtual ResourceContext* GetContext() const = 0;
 
   // The child process unique ID of the requestor.
+  // Use GetWebContentsGetterForRequest instead.

[asanka, 2015/11/25 19:33:02]

Nit: These comments assume that the respective methods are solely used for
eventually getting at a WebContents, which appears to not be the case at least
currently.

[clamy, 2015/11/27 13:29:06]

Done.

   virtual int GetChildID() const = 0;
 
   // The IPC route identifier for this request (this identifies the RenderView
   // or like-thing in the renderer that the request gets routed to).
+  // Use GetWebContentsGetterForRequest instead.
   virtual int GetRouteID() const = 0;
 
   // The pid of the originating process, if the request is sent on behalf of a
   // another process.  Otherwise it is 0.
   virtual int GetOriginPID() const = 0;
 
   // The IPC route identifier of the RenderFrame.
+  // Use GetWebContentsGetterForRequest instead.
   // TODO(jam): once all navigation and resource requests are sent between
   // frames and RenderView/RenderViewHost aren't involved we can remove this and
   // just use GetRouteID above.
   virtual int GetRenderFrameID() const = 0;
 
   // True if GetRenderFrameID() represents a main frame in the RenderView.
   virtual bool IsMainFrame() const = 0;
 
   // True if GetParentRenderFrameID() represents a main frame in the RenderView.
   virtual bool ParentIsMainFrame() const = 0;
@@ skipping 46 matching lines @@
   // Whether this request if using Lo-Fi mode.
   virtual bool IsUsingLoFi() const = 0;
 
  protected:
   virtual ~ResourceRequestInfo() {}
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_RESOURCE_REQUEST_INFO_H_