Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1467533003: Eliminate SkFILE - it always is the same as FILE. (Closed)

Created:
5 years, 1 month ago by hal.canary
Modified:
5 years, 1 month ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Eliminate SkFILE: it always is the same as FILE. Committed: https://skia.googlesource.com/skia/+/d76be9c79baa1530d3dc95c58022e83607a1bb2a

Patch Set 1 #

Patch Set 2 : 2015-11-20 (Friday) 13:56:36 EST #

Patch Set 3 : 2015-11-20 (Friday) 14:01:26 EST #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -78 lines) Patch
M include/core/SkData.h View 2 chunks +7 lines, -6 lines 0 comments Download
M include/core/SkOSFile.h View 4 chunks +17 lines, -17 lines 0 comments Download
M include/core/SkStream.h View 3 chunks +2 lines, -4 lines 0 comments Download
M src/core/SkData.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkStream.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ports/SkOSFile_posix.cpp View 1 3 chunks +6 lines, -6 lines 0 comments Download
M src/ports/SkOSFile_stdio.cpp View 3 chunks +31 lines, -31 lines 0 comments Download
M src/ports/SkOSFile_win.cpp View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M src/utils/SkRTConf.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/utils/SkWhitelistTypefaces.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/DataRefTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/PathOpsSkpClipTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/chrome_fuzz.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
hal.canary
PTAL
5 years, 1 month ago (2015-11-20 18:39:27 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1467533003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1467533003/1
5 years, 1 month ago (2015-11-20 18:39:50 UTC) #4
hal.canary
On 2015/11/20 at 18:53:46, Hal Canary wrote: > Description was changed from > > ========== ...
5 years, 1 month ago (2015-11-20 18:56:20 UTC) #6
mtklein
On 2015/11/20 at 18:56:20, halcanary wrote: > On 2015/11/20 at 18:53:46, Hal Canary wrote: > ...
5 years, 1 month ago (2015-11-20 19:12:37 UTC) #7
hal.canary
On 2015/11/20 at 19:12:37, mtklein wrote: > No one's using SkFILE? A quich search in ...
5 years, 1 month ago (2015-11-20 19:25:06 UTC) #8
mtklein
lgtm
5 years, 1 month ago (2015-11-20 19:30:04 UTC) #9
reed1
lgtm
5 years, 1 month ago (2015-11-20 20:42:52 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1467533003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1467533003/40001
5 years, 1 month ago (2015-11-20 21:12:47 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-11-20 21:47:52 UTC) #13
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/d76be9c79baa1530d3dc95c58022e83607a1bb2a

Powered by Google App Engine
This is Rietveld 408576698