Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp

Issue 1467493002: We mustn't finalize sweeping when V8 started collecting garbage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updates Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp b/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp
index c3b4cc8eb022f32066119c36b08e2de4fc941a77..b142bff25b05b4ad618ad7f4d384ecf0aaec3c00 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp
@@ -274,9 +274,6 @@ void gcPrologueForMajorGC(v8::Isolate* isolate, bool constructRetainedObjectInfo
void V8GCController::gcPrologue(v8::GCType type, v8::GCCallbackFlags flags)
{
- if (ThreadState::current())
- ThreadState::current()->willStartV8GC();
-
haraken 2015/11/20 15:11:35 Would you move this to after ScriptForbiddenScope:
if (isMainThread()) {
ScriptForbiddenScope::enter();
}

Powered by Google App Engine
This is Rietveld 408576698