Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 1467393002: Re-add "ip_address" field to Mac MDNS response fields. (Closed)

Created:
5 years, 1 month ago by Kevin M
Modified:
5 years, 1 month ago
CC:
chromium-reviews, Wez
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-add "ip_address" field to Mac MDNS response fields. cl/1436373002 removed this field from the response, which created inconsistent behavior between service_discovery_client_impl.cc and service_discovery_client_mac.mm. Also added test expectations to catch the regression. BUG=560448 R=vitalybuka@chromium.org CC=wez@chromium.org Committed: https://crrev.com/34957445f6f2bf3c8de2f087d4038bf05e27a030 Cr-Commit-Position: refs/heads/master@{#361187}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/local_discovery/service_discovery_client_mac.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/local_discovery/service_discovery_client_mac_unittest.mm View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Kevin M
5 years, 1 month ago (2015-11-23 19:37:09 UTC) #1
Vitaly Buka (NO REVIEWS)
lgtm
5 years, 1 month ago (2015-11-23 20:41:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1467393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1467393002/1
5 years, 1 month ago (2015-11-23 20:42:07 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-23 21:27:32 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 21:28:14 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/34957445f6f2bf3c8de2f087d4038bf05e27a030
Cr-Commit-Position: refs/heads/master@{#361187}

Powered by Google App Engine
This is Rietveld 408576698