Make chrome/browser/media_galleries compile on Android

Make chrome/browser/media_galleries compile on Android

This is to allow compiling Chrome for Android with use_aura=1.

BUG=507792
Committed: https://crrev.com/5010e358efb0ed2e250597cf071b6e3d258705f0
Cr-Commit-Position: refs/heads/master@{#361273}

[mohsen, 2015-11-23 18:27:14]

mohsen@chromium.org changed reviewers:
+ sievers@chromium.org

[mohsen, 2015-11-23 18:27:14]

sievers@: Can you please take a look...

[Lei Zhang, 2015-11-23 18:38:45]

thestig@chromium.org changed reviewers:
+ thestig@chromium.org

[Lei Zhang, 2015-11-23 18:38:45]

Don't you need c/b/media_galleries/OWNERS or c/OWNERS to review this?

Is there some way to test this locally? I've spent a lot of time trimming the
binary size on Android by making sure things like media_galleries *don't* get
built on Android. So I'm curious how we are going the other way.

[no sievers, 2015-11-23 18:43:40]

https://codereview.chromium.org/1467373002/diff/1/chrome/browser/media_galler...
File chrome/browser/media_galleries/fileapi/mtp_device_map_service.cc (right):

https://codereview.chromium.org/1467373002/diff/1/chrome/browser/media_galler...
chrome/browser/media_galleries/fileapi/mtp_device_map_service.cc:33: //
implementation for Chrome on Android at the moment. (crbug.com/560390)
can we just create a stub that returns null?

https://codereview.chromium.org/1467373002/diff/1/chrome/browser/media_galler...
File chrome/browser/media_galleries/media_folder_finder.cc (right):

https://codereview.chromium.org/1467373002/diff/1/chrome/browser/media_galler...
chrome/browser/media_galleries/media_folder_finder.cc:203: for (size_t i = 0; i
< arraysize(kPrunedPaths); ++i) {
is this because arraysize(kPrunedPaths) is zero on android?
because you could just add DIR_ANDROID_APP_DATA to the list then.

[Lei Zhang, 2015-11-23 21:26:52]

https://codereview.chromium.org/1467373002/diff/1/chrome/browser/media_galler...
File chrome/browser/media_galleries/fileapi/mtp_device_map_service.cc (right):

https://codereview.chromium.org/1467373002/diff/1/chrome/browser/media_galler...
chrome/browser/media_galleries/fileapi/mtp_device_map_service.cc:33: //
implementation for Chrome on Android at the moment. (crbug.com/560390)
On 2015/11/23 18:43:40, sievers wrote:
> can we just create a stub that returns null?

Right, is a no-op CreateMTPDeviceAsyncDelegate() sufficient? Or that plus a stub
MTPDeviceAsyncDelegate?

[mohsen, 2015-11-23 21:33:50]

https://codereview.chromium.org/1467373002/diff/1/chrome/browser/media_galler...
File chrome/browser/media_galleries/fileapi/mtp_device_map_service.cc (right):

https://codereview.chromium.org/1467373002/diff/1/chrome/browser/media_galler...
chrome/browser/media_galleries/fileapi/mtp_device_map_service.cc:33: //
implementation for Chrome on Android at the moment. (crbug.com/560390)
On 2015/11/23 21:26:51, Lei Zhang wrote:
> On 2015/11/23 18:43:40, sievers wrote:
> > can we just create a stub that returns null?
> 
> Right, is a no-op CreateMTPDeviceAsyncDelegate() sufficient? Or that plus a
stub
> MTPDeviceAsyncDelegate?

Done, by creating media_galleries/android/ directory containing the stub
implementation. This directory will contain the actual implementation for
MTPDeviceAsyncDelegate in future. How does it look?

https://codereview.chromium.org/1467373002/diff/1/chrome/browser/media_galler...
File chrome/browser/media_galleries/media_folder_finder.cc (right):

https://codereview.chromium.org/1467373002/diff/1/chrome/browser/media_galler...
chrome/browser/media_galleries/media_folder_finder.cc:203: for (size_t i = 0; i
< arraysize(kPrunedPaths); ++i) {
On 2015/11/23 18:43:40, sievers wrote:
> is this because arraysize(kPrunedPaths) is zero on android?
> because you could just add DIR_ANDROID_APP_DATA to the list then.

Oh, cool. Done.

[Lei Zhang, 2015-11-23 21:37:49]

lgtm

[no sievers, 2015-11-23 21:39:05]

lgtm, thanks

[mohsen, 2015-11-23 21:57:39]

The CQ bit was checked by mohsen@chromium.org

[commit-bot: I haz the power, 2015-11-23 21:58:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1467373002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1467373002/20001

[commit-bot: I haz the power, 2015-11-23 23:46:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-23 23:46:23]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mohsen, 2015-11-24 03:21:03]

The CQ bit was checked by mohsen@chromium.org

[commit-bot: I haz the power, 2015-11-24 03:23:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1467373002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1467373002/20001

[commit-bot: I haz the power, 2015-11-24 04:45:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-24 04:45:56]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mohsen, 2015-11-24 06:29:47]

The CQ bit was checked by mohsen@chromium.org

[commit-bot: I haz the power, 2015-11-24 06:30:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1467373002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1467373002/20001

[commit-bot: I haz the power, 2015-11-24 07:44:51]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-24 07:45:42]

Patchset 2 (id:??) landed as
https://crrev.com/5010e358efb0ed2e250597cf071b6e3d258705f0
Cr-Commit-Position: refs/heads/master@{#361273}