Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1467363002: Skip local variable dependepcies. (Closed)

Created:
5 years, 1 month ago by scheglov
Modified:
5 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Skip local variable dependepcies. This should help with exceptions on bots. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/1fab9b0ecca9058e5e8207e4ff745957ba0be606

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -1 line) Patch
M pkg/analyzer/lib/src/task/dart.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scheglov
5 years, 1 month ago (2015-11-23 18:01:07 UTC) #1
Brian Wilkerson
LGTM
5 years, 1 month ago (2015-11-23 18:09:16 UTC) #2
scheglov
Committed patchset #1 (id:1) manually as 1fab9b0ecca9058e5e8207e4ff745957ba0be606 (presubmit successful).
5 years, 1 month ago (2015-11-23 18:10:20 UTC) #3
Paul Berry
On 2015/11/23 18:10:20, scheglov wrote: > Committed patchset #1 (id:1) manually as > 1fab9b0ecca9058e5e8207e4ff745957ba0be606 (presubmit ...
5 years, 1 month ago (2015-11-23 18:31:55 UTC) #4
scheglov
5 years, 1 month ago (2015-11-23 18:35:57 UTC) #5
Message was sent while issue was closed.
On 2015/11/23 18:31:55, Paul Berry wrote:
> On 2015/11/23 18:10:20, scheglov wrote:
> > Committed patchset #1 (id:1) manually as
> > 1fab9b0ecca9058e5e8207e4ff745957ba0be606 (presubmit successful).
> 
> Is this intended as a permanent fix or a temporary measure?  I'm concerned
about
> what will happen with cases like this:
> 
> final a = () {
>   final b = c;
> }();
> final c = 1;
> 
> What type will we infer for a?  Will it depend on the relative order of
running
> type propagation on a and c?

We cannot set the propagated type of "a" in this case.
And AFAIK we don't propagate function return types except for a very limited
case.

Powered by Google App Engine
This is Rietveld 408576698