Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1467343002: Create an interface between ChromePasswordManagerClient and ManagePasswordsUIController (Closed)

Created:
5 years, 1 month ago by vasilii
Modified:
5 years, 1 month ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Create an interface between ChromePasswordManagerClient and ManagePasswordsUIController BUG=557128 Committed: https://crrev.com/d517f8462d0420217db3420c134a05c0feb552fb Cr-Commit-Position: refs/heads/master@{#361309}

Patch Set 1 #

Total comments: 2

Patch Set 2 : changed a comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -106 lines) Patch
M chrome/browser/password_manager/chrome_password_manager_client.cc View 6 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_test.h View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_test.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_ui_controller.h View 2 chunks +12 lines, -36 lines 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_ui_controller.cc View 5 chunks +48 lines, -48 lines 0 comments Download
A chrome/browser/ui/passwords/passwords_client_ui_delegate.h View 1 1 chunk +78 lines, -0 lines 0 comments Download
A + chrome/browser/ui/passwords/passwords_client_ui_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
vasilii
Hi Vaclav, please review the CL.
5 years, 1 month ago (2015-11-23 17:29:24 UTC) #2
vabr (Chromium)
LGTM, thanks for this improvement! Vaclav https://codereview.chromium.org/1467343002/diff/1/chrome/browser/ui/passwords/passwords_client_ui_delegate.h File chrome/browser/ui/passwords/passwords_client_ui_delegate.h (right): https://codereview.chromium.org/1467343002/diff/1/chrome/browser/ui/passwords/passwords_client_ui_delegate.h#newcode33 chrome/browser/ui/passwords/passwords_client_ui_delegate.h:33: // Called when ...
5 years, 1 month ago (2015-11-23 17:45:45 UTC) #3
vasilii
https://codereview.chromium.org/1467343002/diff/1/chrome/browser/ui/passwords/passwords_client_ui_delegate.h File chrome/browser/ui/passwords/passwords_client_ui_delegate.h (right): https://codereview.chromium.org/1467343002/diff/1/chrome/browser/ui/passwords/passwords_client_ui_delegate.h#newcode33 chrome/browser/ui/passwords/passwords_client_ui_delegate.h:33: // Called when the user submits a change password ...
5 years, 1 month ago (2015-11-24 09:40:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1467343002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1467343002/20001
5 years, 1 month ago (2015-11-24 09:41:38 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-24 10:46:35 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-24 10:47:37 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/d517f8462d0420217db3420c134a05c0feb552fb
Cr-Commit-Position: refs/heads/master@{#361309}

Powered by Google App Engine
This is Rietveld 408576698