Issue 1467333002: Revert of skstd -> std for unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1467333002: Revert of skstd -> std for unique_ptr (Closed)

Created:
5 years ago by mtklein

Modified:
5 years ago

Reviewers:
bungeman-skia, mtklein_C

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Revert of skstd -> std for unique_ptr (patchset #16 id:300001 of https://codereview.chromium.org/1436033003/ ) Reason for revert: Perf-Mac10.9-Clang-MacMini6.2-CPU-AVX-x86_64-Release has not updated yet. Original issue's description: > skstd -> std for unique_ptr > > TBR=reed@google.com > No public API changes. > > BUG=skia:4564 > > Committed: https://skia.googlesource.com/skia/+/755c553c17b82bb5de3d9cc8d3b2a866ff9e9e50 > > CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot,Build-Ubuntu-GCC-x86_64-Debug-CrOS_Link-Trybot > > Committed: https://skia.googlesource.com/skia/+/06189155d987db5c7e69015f6ea87c2168d6a065 TBR=bungeman@google.com,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4564 Committed: https://skia.googlesource.com/skia/+/dfd7d48ced44026aafca71ecb5f0138af8125b94

Patch Set 1 #

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+493 lines, -30 lines)			Patch
M	gyp/core.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	include/core/SkRefCnt.h	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	include/core/SkTypes.h	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	include/private/SkOncePtr.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	include/private/SkTemplates.h	View	4 chunks	+13 lines, -13 lines	0 comments	Download
A	include/private/SkUniquePtr.h	View	1 chunk	+396 lines, -0 lines	0 comments	Download
M	src/android/SkBitmapRegionDecoder.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/core/SkSharedMutex.h	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	tests/CPlusPlusEleven.cpp	View	1 chunk	+69 lines, -0 lines	0 comments	Download
M	tools/BUILD.public.expected	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1467333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1467333002/1

5 years ago (2015-11-23 17:19:27 UTC) #2

commit-bot: I haz the power

5 years ago (2015-11-23 17:19:39 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/dfd7d48ced44026aafca71ecb5f0138af8125b94

Expand Messages | Collapse Messages