Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: tests/language/language_dart2js.status

Issue 146733003: Handle type checking of generic compile time constants. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Add regression test. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/language/language_dart2js.status
diff --git a/tests/language/language_dart2js.status b/tests/language/language_dart2js.status
index 0ba19e3ab44d9522eda2011a449c64bd5257855f..31e4e0242315b840b7668587370439bc9729786f 100644
--- a/tests/language/language_dart2js.status
+++ b/tests/language/language_dart2js.status
@@ -60,8 +60,19 @@ assertion_test: RuntimeError # Issue 12748
double_to_string_as_exponential2_test: RuntimeError # Issue 12749
double_to_string_as_fixed2_test: RuntimeError # Issue 12749
double_to_string_as_precision2_test: RuntimeError # Issue 12749
-list_literal1_test/01: MissingCompileTimeError, OK # Checked mode test.
-map_literal1_test/01: MissingCompileTimeError, OK # Checked mode test.
+generic_test: RuntimeError, OK
+named_parameters_type_test/01: MissingRuntimeError, OK
+named_parameters_type_test/02: MissingRuntimeError, OK
+named_parameters_type_test/03: MissingRuntimeError, OK
+positional_parameters_type_test/01: MissingRuntimeError, OK
+positional_parameters_type_test/02: MissingRuntimeError, OK
+issue13474_test: RuntimeError, OK
+
+[ $compiler == dart2js && $unchecked ]
+# This section is for tests that intentionally have incompatible behavior in
+# unchecked and checked mode. For instance tests for type errors in compile
+# time constants, which cause static type warnings in unchecked mode and
+# compile-time errors in checked mode.
karlklose 2014/01/29 10:44:23 Ditto.
Johnni Winther 2014/01/30 08:25:23 Done.
compile_time_constant_checked_test/02: MissingCompileTimeError, OK
compile_time_constant_checked2_test/01: MissingCompileTimeError, OK
compile_time_constant_checked2_test/02: MissingCompileTimeError, OK
@@ -76,13 +87,16 @@ compile_time_constant_checked3_test/04: MissingCompileTimeError, OK
compile_time_constant_checked3_test/05: MissingCompileTimeError, OK
compile_time_constant_checked3_test/06: MissingCompileTimeError, OK
malformed2_test/01: MissingCompileTimeError, OK
-generic_test: RuntimeError, OK
-named_parameters_type_test/01: MissingRuntimeError, OK
-named_parameters_type_test/02: MissingRuntimeError, OK
-named_parameters_type_test/03: MissingRuntimeError, OK
-positional_parameters_type_test/01: MissingRuntimeError, OK
-positional_parameters_type_test/02: MissingRuntimeError, OK
-issue13474_test: RuntimeError, OK
+list_literal1_test/01: MissingCompileTimeError, OK
+map_literal1_test/01: MissingCompileTimeError, OK
+const_constructor2_test/13: MissingCompileTimeError, OK
+const_constructor2_test/14: MissingCompileTimeError, OK
+const_constructor2_test/15: MissingCompileTimeError, OK
+const_constructor2_test/16: MissingCompileTimeError, OK
+const_constructor2_test/17: MissingCompileTimeError, OK
+const_constructor2_test/20: MissingCompileTimeError, OK
+const_constructor2_test/22: MissingCompileTimeError, OK
+const_constructor2_test/24: MissingCompileTimeError, OK
[ $compiler == dart2js && $minified ]
cyclic_type_test: Fail # Issue 12605
@@ -297,6 +311,14 @@ compile_time_constant_checked3_test/04: Fail, OK
compile_time_constant_checked3_test/05: Fail, OK
compile_time_constant_checked3_test/06: Fail, OK
malformed2_test/01: Fail, OK
+const_constructor2_test/13: Fail, OK
+const_constructor2_test/14: Fail, OK
+const_constructor2_test/15: Fail, OK
+const_constructor2_test/16: Fail, OK
+const_constructor2_test/17: Fail, OK
+const_constructor2_test/20: Fail, OK
+const_constructor2_test/22: Fail, OK
+const_constructor2_test/24: Fail, OK
[ $compiler == dart2dart && $checked ]
# Dart VM problems

Powered by Google App Engine
This is Rietveld 408576698