Issue 146733002: [DevTools] Dock to left mode.

Issue 146733002: [DevTools] Dock to left mode. (Closed)

Created:
6 years, 11 months ago by dgozman

Modified:
6 years, 11 months ago

Reviewers:
vsevik, pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

[DevTools] Dock to left mode. BUG=134282 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165820

Patch Set 1 : #

Total comments: 4

Patch Set 2 : Made an experiment #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+68 lines, -20 lines)			Patch
M	Source/devtools/front_end/DockController.js	View	1	4 chunks	+27 lines, -3 lines	0 comments	Download
M	Source/devtools/front_end/ElementsPanel.js	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	Source/devtools/front_end/Images/src/statusbarButtonGlyphs.svg	View		5 chunks	+9 lines, -3 lines	0 comments	Download
M	Source/devtools/front_end/Images/statusbarButtonGlyphs.png	View		Binary file		0 comments	Download
M	Source/devtools/front_end/Images/statusbarButtonGlyphs2x.png	View		Binary file		0 comments	Download
M	Source/devtools/front_end/InspectorView.js	View	1	4 chunks	+19 lines, -9 lines	0 comments	Download
M	Source/devtools/front_end/Settings.js	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/devtools/front_end/SettingsScreen.js	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	Source/devtools/front_end/SourcesPanel.js	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	Source/devtools/front_end/inspector.css	View		2 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

pfeldman

Can we land it behind experiment? https://codereview.chromium.org/146733002/diff/50001/Source/devtools/front_end/InspectorView.js File Source/devtools/front_end/InspectorView.js (right): https://codereview.chromium.org/146733002/diff/50001/Source/devtools/front_end/InspectorView.js#newcode57 Source/devtools/front_end/InspectorView.js:57: this._devtoolsView = new ...

6 years, 11 months ago (2014-01-24 13:22:56 UTC) #2

dgozman

PTAL https://codereview.chromium.org/146733002/diff/50001/Source/devtools/front_end/InspectorView.js File Source/devtools/front_end/InspectorView.js (right): https://codereview.chromium.org/146733002/diff/50001/Source/devtools/front_end/InspectorView.js#newcode57 Source/devtools/front_end/InspectorView.js:57: this._devtoolsView = new WebInspector.View(); On 2014/01/24 13:22:57, pfeldman ...

6 years, 11 months ago (2014-01-24 14:03:48 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/146733002/120001

6 years, 11 months ago (2014-01-26 10:35:26 UTC) #5

Message was sent while issue was closed.

Change committed as 165820

Expand Messages | Collapse Messages