Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 1467283002: Update gtest to 786564fa4a3c8e0f908acca32cce481de5481b9f (Closed)

Created:
5 years, 1 month ago by Mark Mentovai
Modified:
5 years, 1 month ago
Reviewers:
scottmg
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

Update gtest to 786564fa4a3c8e0f908acca32cce481de5481b9f 8b085f0d2168 Fix warnings encountered in MSVC build of gtest/gmock tests 322a4914a309 Better use of character constants cbce23fb8670 Leave decltype(max_ulps_) alone and cast, not sure this is better cfe466a0a753 Use a templated helper to wrap the cast 4a8e54401e49 Name the helper AsBits() 786564fa4a3c Merge pull request #627 from mark-chromium/tests_msvs R=scottmg@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/c60ec9beeb8e5a30457095eade1b1fa8a56052fe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
Along with the mini_chromium /bigobj fix, this allows us to build and run gtest’s and ...
5 years, 1 month ago (2015-11-23 15:51:20 UTC) #2
scottmg
lgtm
5 years, 1 month ago (2015-11-23 17:44:36 UTC) #3
Mark Mentovai
5 years, 1 month ago (2015-11-23 18:17:16 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c60ec9beeb8e5a30457095eade1b1fa8a56052fe (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698