third_party/libpng: update to 1.2.54

third_party/libpng: update to 1.2.54

TBR=darin@chromium.org
BUG=560291
Committed: https://crrev.com/7f3d85b096f66870a15b37c2f40b219b2e292693
Cr-Commit-Position: refs/heads/master@{#362298}

[mdempsky, 2015-11-23 18:11:37]

mdempsky@chromium.org changed reviewers:
+ inferno@chromium.org, noel@chromium.org

[mdempsky, 2015-11-23 22:18:27]

Hrm, browser_test has failed 3/3 times on the linux_chromium_chromeos_rel_ng
trybot.  All 3 times due to DownloadNotificationTest test, but the first time
was due to:

    DownloadNotificationTest.DownloadCancelledExternally

whereas the second and third times have been due to:

    DownloadNotificationTest.CloseNotificationAfterDownload
    DownloadNotificationTest.DownloadRemoved
    DownloadNotificationTest.IncognitoDownloadFile
    DownloadNotificationTest.InterruptDownload
    DownloadNotificationTest.SimultaneousIncognitoAndNormalDownloads

[Noel Gordon, 2015-11-24 07:06:15]

On 2015/11/23 22:18:27, mdempsky wrote:
> Hrm, browser_test has failed 3/3 times on the linux_chromium_chromeos_rel_ng
> trybot.  All 3 times due to DownloadNotificationTest test, but the first time
> was due to:
> 
>     DownloadNotificationTest.DownloadCancelledExternally
> 
> whereas the second and third times have been due to:
> 
>     DownloadNotificationTest.CloseNotificationAfterDownload
>     DownloadNotificationTest.DownloadRemoved
>     DownloadNotificationTest.IncognitoDownloadFile
>     DownloadNotificationTest.InterruptDownload
>     DownloadNotificationTest.SimultaneousIncognitoAndNormalDownloads

crbug.com/570329 fix in progress.

[Noel Gordon, 2015-11-24 07:07:14]

On 2015/11/24 07:06:15, noel gordon wrote:
> On 2015/11/23 22:18:27, mdempsky wrote:
> > Hrm, browser_test has failed 3/3 times on the linux_chromium_chromeos_rel_ng
> > trybot.  All 3 times due to DownloadNotificationTest test, but the first
time
> > was due to:
> > 
> >     DownloadNotificationTest.DownloadCancelledExternally
> > 
> > whereas the second and third times have been due to:
> > 
> >     DownloadNotificationTest.CloseNotificationAfterDownload
> >     DownloadNotificationTest.DownloadRemoved
> >     DownloadNotificationTest.IncognitoDownloadFile
> >     DownloadNotificationTest.InterruptDownload
> >     DownloadNotificationTest.SimultaneousIncognitoAndNormalDownloads
> 
> crbug.com/570329 fix in progress.

Ahem, crbug.com/560329

https://code.google.com/p/chromium/issues/detail?id=560329

[Noel Gordon, 2015-11-24 07:18:14]

This patch could change webkit rendering behavior, and the bots don't test that.


Please add third_party/WebKit/Tools/whitespace_file.txt to your patch, add some
relevant comment within that file, and re-upload your patch again, and dry run.

[Noel Gordon, 2015-11-24 19:37:52]

The CQ bit was checked by noel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-24 19:40:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1467263003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1467263003/1

[Noel Gordon, 2015-11-24 20:00:10]

https://codereview.chromium.org/1467263003/diff/1/third_party/libpng/pngset.c
File third_party/libpng/pngset.c (right):

https://codereview.chromium.org/1467263003/diff/1/third_party/libpng/pngset.c...
third_party/libpng/pngset.c:461: 
This code differs from current pngset.c per the libpng1.2 branch history [1]. 
How come?

[1]
http://sourceforge.net/p/libpng/code/ci/bf2feb235f5f06c5dbe162e69691be409f02f...

[mdempsky, 2015-11-24 20:04:01]

On 2015/11/24 20:00:10, noel gordon wrote:
> This code differs from current pngset.c per the libpng1.2 branch history [1]. 
> How come?
> 
> [1]
>
http://sourceforge.net/p/libpng/code/ci/bf2feb235f5f06c5dbe162e69691be409f02f...

Because the last two commits there were made after the libpng 1.2.54 release.

[commit-bot: I haz the power, 2015-11-24 21:17:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-24 21:17:29]

Dry run: This issue passed the CQ dry run.

[Noel Gordon, 2015-11-24 22:50:33]

On 2015/11/24 20:04:01, mdempsky wrote:
> On 2015/11/24 20:00:10, noel gordon wrote:
> > This code differs from current pngset.c per the libpng1.2 branch history
[1]. 
> > How come?
> > 
> > [1]
> >
>
http://sourceforge.net/p/libpng/code/ci/bf2feb235f5f06c5dbe162e69691be409f02f...
> 
> Because the last two commits there were made after the libpng 1.2.54 release.

Well
http://sourceforge.net/p/libpng/code/ci/475bab6170f651b9863e9fc1b8ffd6cd89a45...
fixed the PLTE bug and was in the 1.2.54, the and the CL has that code (good).

But the next change,
http://sourceforge.net/p/libpng/code/ci/ad224c6907e8a274f2679eae4c2e3085fdc7e...
looks to say that there was an error in the PLTE fix, no?

[mdempsky, 2015-11-24 23:31:26]

On 2015/11/24 22:50:33, noel gordon wrote:
> Well
>
http://sourceforge.net/p/libpng/code/ci/475bab6170f651b9863e9fc1b8ffd6cd89a45...
> fixed the PLTE bug and was in the 1.2.54, the and the CL has that code (good).
> 
> But the next change,
>
http://sourceforge.net/p/libpng/code/ci/ad224c6907e8a274f2679eae4c2e3085fdc7e...
> looks to say that there was an error in the PLTE fix, no?

It does.  What do you think should be done about that?  Import 1.2.54 + fixed
pngset.c?  Wait for 1.2.55?  Something else?

[Noel Gordon, 2015-11-25 00:17:51]

Let's take 1.2.54 fix as is. Add a note to the bug about
http://sourceforge.net/p/libpng/code/ci/ad224c6907e8a274f2679eae4c2e3085fdc7e...
suggesting we might need to change this again to actually fix the problem (TBD).

Then, to move on to submit, let's follow #6 above.

"This patch could change webkit rendering behavior, and the bots don't test
that.

Please add third_party/WebKit/Tools/whitespace_file.txt to your patch, add some
relevant comment within that file, and re-upload your patch again, and dry run."

[Noel Gordon, 2015-11-30 05:56:22]

On 2015/11/25 00:17:51, noel gordon wrote:

> Please add third_party/WebKit/Tools/whitespace_file.txt to your patch, add
some
> relevant comment within that file, and re-upload your patch again, and dry
run."

Well, third_party/WebKit/Tools/whitespace_file.txt was removed last week. You
will need to run the wekit tests locally with this CL to determine the list of
layuot test cases that change behavior.

[Noel Gordon, 2015-11-30 06:42:06]

Hmmm, another way is to manually add the layout test bots.

[Noel Gordon, 2015-11-30 08:14:04]

On 2015/11/30 06:42:06, noel gordon wrote:
> Hmmm, another way is to manually add the layout test bots.

Seems to pass.  LGTM

[Noel Gordon, 2015-11-30 09:13:35]

Description was changed from

==========
third_party/libpng: update to 1.2.54

BUG=560291
==========

to

==========
third_party/libpng: update to 1.2.54

TBR=darin@chromium.org
BUG=560291
==========

[mdempsky, 2015-11-30 22:36:49]

On 2015/11/30 08:14:04, noel gordon wrote:
> On 2015/11/30 06:42:06, noel gordon wrote:
> > Hmmm, another way is to manually add the layout test bots.

Are those the {linux,mac,win}_blink_rel bots?

> Seems to pass.  LGTM

Thanks!

[mdempsky, 2015-11-30 22:37:00]

The CQ bit was checked by mdempsky@chromium.org

[commit-bot: I haz the power, 2015-11-30 22:40:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1467263003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1467263003/1

[Noel Gordon, 2015-11-30 22:53:27]

On 2015/11/30 22:36:49, mdempsky wrote:
> On 2015/11/30 08:14:04, noel gordon wrote:
> > On 2015/11/30 06:42:06, noel gordon wrote:
> > > Hmmm, another way is to manually add the layout test bots.
> 
> Are those the {linux,mac,win}_blink_rel bots?

Yeap. I believe they are being turned down soon or some such, but they ran the
blink layout tests when I manually added them as trys.

> > Seems to pass.  LGTM
> 
> Thanks!

np, thx for the patch.

[Noel Gordon, 2015-12-01 00:06:56]

mdempsky@: linux_chromium_asan_rel_ng is unhappy, could you investigate please?

[Noel Gordon, 2015-12-01 00:09:55]

On 2015/11/25 00:17:51, noel gordon wrote:
> Let's take 1.2.54 fix as is. Add a note to the bug about
>
http://sourceforge.net/p/libpng/code/ci/ad224c6907e8a274f2679eae4c2e3085fdc7e...
> suggesting we might need to change this again to actually fix the problem
(TBD).

^^^ Have you done this part, btw :) ?

[mdempsky, 2015-12-01 00:23:42]

On 2015/12/01 00:09:55, noel gordon wrote:
> On 2015/11/25 00:17:51, noel gordon wrote:
> > Let's take 1.2.54 fix as is. Add a note to the bug about
> >
>
http://sourceforge.net/p/libpng/code/ci/ad224c6907e8a274f2679eae4c2e3085fdc7e...
> > suggesting we might need to change this again to actually fix the problem
> (TBD).
> 
> ^^^ Have you done this part, btw :) ?

Ah, I thought you wanted to wait for 1.2.55 for that fix.  If you think it
should go in now, I can prepare a CL for backporting it.  (Would be nice if it
fixes the asan problem...)

[Noel Gordon, 2015-12-01 00:32:30]

Yeah if we need to port in the 1.255 fix to make asan happy, yeah we'd do that. 
Let's wait to see if the asan bot complains a second time - might be a flake -
and decide then.

[commit-bot: I haz the power, 2015-12-01 00:49:00]

Description was changed from

==========
third_party/libpng: update to 1.2.54

TBR=darin@chromium.org
BUG=560291
==========

to

==========
third_party/libpng: update to 1.2.54

TBR=darin@chromium.org
BUG=560291
==========

[commit-bot: I haz the power, 2015-12-01 00:49:00]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-01 00:50:38]

Description was changed from

==========
third_party/libpng: update to 1.2.54

TBR=darin@chromium.org
BUG=560291
==========

to

==========
third_party/libpng: update to 1.2.54

TBR=darin@chromium.org
BUG=560291

Committed: https://crrev.com/7f3d85b096f66870a15b37c2f40b219b2e292693
Cr-Commit-Position: refs/heads/master@{#362298}
==========

[commit-bot: I haz the power, 2015-12-01 00:50:38]

Patchset 1 (id:??) landed as
https://crrev.com/7f3d85b096f66870a15b37c2f40b219b2e292693
Cr-Commit-Position: refs/heads/master@{#362298}

[Noel Gordon, 2015-12-01 01:39:45]

Landed. The linux asan bot bleep was a flake ...

> On 2015/11/25 00:17:51, noel gordon wrote:
> > Let's take 1.2.54 fix as is. Add a note to the bug about
> >
>
http://sourceforge.net/p/libpng/code/ci/ad224c6907e8a274f2679eae4c2e3085fdc7e...
> > suggesting we might need to change this again to actually fix the problem
> (TBD).
> 

... so the washup TODO is to add the note the bug and we are all done.