Issue 146723004: android envsetup: Stop exporting ANDROID_TOOLCHAIN.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 146723004: android envsetup: Stop exporting ANDROID_TOOLCHAIN. (Closed)

Created:
6 years, 10 months ago by Nico

Modified:
6 years, 10 months ago

Reviewers:
Torne

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

android envsetup: Stop exporting ANDROID_TOOLCHAIN. build/common.gypi already sets <(android_toolchain) independently of this env var, and nothing seems to really depend on the env var. (tools/telemetry/telemetry/core/platform/profiler/perf_profiler.py uses it to print a better error message if it's available, but that doesn't seem important.) BUG=330631 R=torne@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250141

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -47 lines)			Patch
	M	build/android/envsetup_functions.sh	View	1 2	3 chunks	+2 lines, -47 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Nico

This is made possible by the STRIP cl (STRIP needed ANDROID_TOOLCHAIN). Again there's two try ...

6 years, 10 months ago (2014-02-10 04:02:30 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/146723004/60001

6 years, 10 months ago (2014-02-10 17:44:10 UTC) #4

Nico

6 years, 10 months ago (2014-02-10 17:50:46 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r250141 (presubmit successful).

Expand Messages | Collapse Messages

Issue 146723004: android envsetup: Stop exporting ANDROID_TOOLCHAIN. (Closed)

Description

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Messages