Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 1467213002: Revert of [heap] Preserve optimized code maps accross GCs. (Closed)

Created:
5 years, 1 month ago by Hannes Payer (out of office)
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com, Michael Hablich, Jakob Kummerow
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Preserve optimized code maps accross GCs. (patchset #1 id:1 of https://codereview.chromium.org/1430293002/ ) Reason for revert: Janks finalization of full GC. Original issue's description: > [heap] Preserve optimized code maps accross GCs. > > This disables the eager flushing of optimized code maps during full GCs > and instead treats entries in those tables weakly by default. Note that > for now entries are removed when one of its components dies. > > R=mvstanton@chromium.org > > Committed: https://crrev.com/7a1377aab2ba4e2c9a7d422b51f645cbbaec10c7 > Cr-Commit-Position: refs/heads/master@{#32045} TBR=mvstanton@chromium.org,mstarzinger@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/78174a426d17c99aa899102220446dfd5b053fe5 Cr-Commit-Position: refs/heads/master@{#32173}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Hannes Payer (out of office)
Created Revert of [heap] Preserve optimized code maps accross GCs.
5 years, 1 month ago (2015-11-23 12:06:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1467213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1467213002/1
5 years, 1 month ago (2015-11-23 12:06:53 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-23 12:07:06 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/78174a426d17c99aa899102220446dfd5b053fe5 Cr-Commit-Position: refs/heads/master@{#32173}
5 years, 1 month ago (2015-11-23 12:07:51 UTC) #4
Michael Starzinger
5 years, 1 month ago (2015-11-23 12:30:15 UTC) #5
Message was sent while issue was closed.
LGTM.

Powered by Google App Engine
This is Rietveld 408576698