Add the filename to the loaded trace file information.

Add the filename to the loaded trace file information.

This will allow us to see the names of the loaded trace files in the
trace viewer header.

BUG=trace-viewer:108
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202483

[dsinclair, 2013-05-09 19:26:51]

nduca PTAL.

[nduca, 2013-05-13 19:43:41]

lgtm but with minor nit.

And i assume you'll include a DEPS roll in this cl?

[nduca, 2013-05-13 19:43:46]

https://codereview.chromium.org/14672019/diff/1/content/browser/tracing/traci...
File content/browser/tracing/tracing_ui.cc (right):

https://codereview.chromium.org/14672019/diff/1/content/browser/tracing/traci...
content/browser/tracing/tracing_ui.cc:365: 
i think if we switch from ExecuteJavascriptInWebFrame to CallFunction, then
it'll do the escaping for us... then we'd just have to
ExecuteJavascriptInWebFrame(delete window.tracedata). That'd probably be a lot
cleaner).

[dsinclair, 2013-05-16 20:45:44]

On 2013/05/13 19:43:46, nduca wrote:
>
https://codereview.chromium.org/14672019/diff/1/content/browser/tracing/traci...
> File content/browser/tracing/tracing_ui.cc (right):
> 
>
https://codereview.chromium.org/14672019/diff/1/content/browser/tracing/traci...
> content/browser/tracing/tracing_ui.cc:365: 
> i think if we switch from ExecuteJavascriptInWebFrame to CallFunction, then
> it'll do the escaping for us... then we'd just have to
> ExecuteJavascriptInWebFrame(delete window.tracedata). That'd probably be a lot
> cleaner).

If we use CallJsonFunction, how do I pass the window.traceData parameter? I
can't send it as a string as it will become "window.traceData", I can't send it
as binary since we don't serialize binary Value types to JSON.

Or, do I pass the whole javascript string through the CallJavascriptFunction
instead of writing it to window.traceData?

[nduca, 2013-05-16 21:57:31]

oh naw good point. keep it as it is. maybe make a comment about the issue.

[dsinclair, 2013-05-17 14:09:31]

On 2013/05/16 21:57:31, nduca wrote:
> oh naw good point. keep it as it is. maybe make a comment about the issue.

PTAL.

I switched the custom escape code for base::GetGetDoubleQuotedJson and just
wanted to make sure there were no issues you saw with that.

[nduca, 2013-05-17 23:14:41]

lgtm

[nduca, 2013-05-17 23:15:12]

https://codereview.chromium.org/14672019/diff/10001/content/browser/tracing/t...
File content/browser/tracing/tracing_ui.cc (right):

https://codereview.chromium.org/14672019/diff/10001/content/browser/tracing/t...
content/browser/tracing/tracing_ui.cc:357:
base::GetDoubleQuotedJson(path.value()) + ");" +
do you have to call path.reserve(path.lenght*2) like nick did in his patch?

[commit-bot: I haz the power, 2013-05-27 18:52:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dsinclair@chromium.org/14672019/15001

[commit-bot: I haz the power, 2013-05-27 20:56:53]

Retried try job too often on linux_chromeos for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-05-28 01:10:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dsinclair@chromium.org/14672019/15001

[commit-bot: I haz the power, 2013-05-28 02:28:18]

Change committed as 202483