chrome/browser/ui/toolbar/toolbar_model_impl.cc - Issue 1467193003: Componentize error pages strings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/toolbar/toolbar_model_impl.cc

Issue 1467193003: Componentize error pages strings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Split out tracing_resources fix Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/toolbar/toolbar_model_impl.cc

diff --git a/chrome/browser/ui/toolbar/toolbar_model_impl.cc b/chrome/browser/ui/toolbar/toolbar_model_impl.cc

index 0cefbc6b0e367c96cecee20b110e111835a707ad..e0e59998b3dbe352b191d2a73b009daf0cee99be 100644

--- a/chrome/browser/ui/toolbar/toolbar_model_impl.cc

+++ b/chrome/browser/ui/toolbar/toolbar_model_impl.cc

@@ -29,6 +29,7 @@

#include "content/public/common/content_constants.h"

#include "content/public/common/ssl_status.h"

#include "grit/components_scaled_resources.h"

+#include "grit/components_strings.h"

mmenke 2015/11/30 23:29:10 Why is this one needed? This file doesn't use a s

blundell 2015/12/01 11:33:44 Good catch. IDS_SECURE_CONNECTION_EV was buried am

#include "grit/theme_resources.h"

#include "net/cert/cert_status_flags.h"

#include "net/cert/x509_certificate.h"