Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 1467143006: [Telemetry] Migrate find_dependencies internals to tools/perf (Closed)

Created:
5 years ago by eakuefner
Modified:
5 years ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Migrate find_dependencies internals to tools/perf Now that tools/perf/find_dependencies is the only find_dependencies, this CL moves all the related under-the-hood code to tools/perf/core. It also moves the davclient dependency out of tools/telemetry, since find_dependencies is the only user of it. BUG=528331 TEST=tools/perf/find_dependencies Committed: https://crrev.com/5ad8167a84a095e7b9852032966fe5ee6935c6ee Cr-Commit-Position: refs/heads/master@{#361256}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Address Ned's comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -872 lines) Patch
A + tools/perf/core/bootstrap.py View 1 chunk +1 line, -0 lines 0 comments Download
A + tools/perf/core/find_dependencies.py View 5 chunks +9 lines, -7 lines 0 comments Download
A + tools/perf/core/find_dependencies_unittest.py View 1 chunk +2 lines, -1 line 0 comments Download
A + tools/perf/core/telemetry_dependencies_unittest.py View 1 3 chunks +11 lines, -16 lines 0 comments Download
M tools/perf/find_dependencies View 1 chunk +1 line, -4 lines 0 comments Download
A + tools/perf/third_party/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/perf/third_party/davclient/README.chromium View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/perf/third_party/davclient/davclient.py View 0 chunks +-1 lines, --1 lines 0 comments Download
D tools/telemetry/telemetry/TELEMETRY_DEPS View 1 1 chunk +0 lines, -14 lines 0 comments Download
D tools/telemetry/telemetry/internal/util/bootstrap.py View 1 chunk +0 lines, -160 lines 0 comments Download
D tools/telemetry/telemetry/internal/util/find_dependencies.py View 1 chunk +0 lines, -241 lines 0 comments Download
D tools/telemetry/telemetry/internal/util/find_dependencies_unittest.py View 1 chunk +0 lines, -38 lines 0 comments Download
D tools/telemetry/telemetry/telemetry_dependencies_unittest.py View 1 chunk +0 lines, -65 lines 0 comments Download
D tools/telemetry/third_party/davclient/README.chromium View 1 chunk +0 lines, -17 lines 0 comments Download
D tools/telemetry/third_party/davclient/davclient.py View 1 chunk +0 lines, -312 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
eakuefner
5 years ago (2015-11-23 22:44:08 UTC) #3
nednguyen
lgtm Thanks! https://codereview.chromium.org/1467143006/diff/1/tools/perf/core/telemetry_dependencies_unittest.py File tools/perf/core/telemetry_dependencies_unittest.py (right): https://codereview.chromium.org/1467143006/diff/1/tools/perf/core/telemetry_dependencies_unittest.py#newcode17 tools/perf/core/telemetry_dependencies_unittest.py:17: path.GetTelemetryDir(), 'telemetry', 'TELEMETRY_DEPS') Also move TELEMETRY_DEPS to ...
5 years ago (2015-11-23 22:52:05 UTC) #4
aiolos (Not reviewing)
https://codereview.chromium.org/1467143006/diff/1/tools/perf/core/telemetry_dependencies_unittest.py File tools/perf/core/telemetry_dependencies_unittest.py (right): https://codereview.chromium.org/1467143006/diff/1/tools/perf/core/telemetry_dependencies_unittest.py#newcode17 tools/perf/core/telemetry_dependencies_unittest.py:17: path.GetTelemetryDir(), 'telemetry', 'TELEMETRY_DEPS') On 2015/11/23 22:52:05, nednguyen wrote: > ...
5 years ago (2015-11-23 22:53:25 UTC) #5
eakuefner
https://codereview.chromium.org/1467143006/diff/1/tools/perf/core/telemetry_dependencies_unittest.py File tools/perf/core/telemetry_dependencies_unittest.py (right): https://codereview.chromium.org/1467143006/diff/1/tools/perf/core/telemetry_dependencies_unittest.py#newcode17 tools/perf/core/telemetry_dependencies_unittest.py:17: path.GetTelemetryDir(), 'telemetry', 'TELEMETRY_DEPS') On 2015/11/23 at 22:52:05, nednguyen wrote: ...
5 years ago (2015-11-23 23:29:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1467143006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1467143006/20001
5 years ago (2015-11-23 23:30:23 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/133196)
5 years ago (2015-11-24 03:12:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1467143006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1467143006/20001
5 years ago (2015-11-24 04:08:41 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-24 04:46:22 UTC) #14
commit-bot: I haz the power
5 years ago (2015-11-24 04:46:55 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5ad8167a84a095e7b9852032966fe5ee6935c6ee
Cr-Commit-Position: refs/heads/master@{#361256}

Powered by Google App Engine
This is Rietveld 408576698