Remove AttributeCollection's findIndex(Attr*) by using QualifiedName

third_party/WebKit/Source/core/dom/AttributeCollection.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  * Copyright (C) 2014 Apple Inc. All rights reserved.
  * Copyright (C) 2014 Samsung Electronics. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
@@ skipping 15 matching lines @@
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef AttributeCollection_h
 #define AttributeCollection_h
 
-#include "core/dom/Attr.h"
 #include "core/dom/Attribute.h"
 #include "wtf/Allocator.h"
 #include "wtf/Vector.h"
 
 namespace blink {
 
 template <typename Container, typename ContainerMemberType = Container>
 class AttributeCollectionGeneric {
     STACK_ALLOCATED();
 public:
@@ skipping 14 matching lines @@
     iterator begin() const { return m_attributes.data(); }
     iterator end() const { return begin() + size(); }
 
     unsigned size() const { return m_attributes.size(); }
     bool isEmpty() const { return !size(); }
 
     iterator find(const QualifiedName&) const;
     iterator find(const AtomicString& name, bool shouldIgnoreCase) const;
     size_t findIndex(const QualifiedName&, bool shouldIgnoreCase = false) const;
     size_t findIndex(const AtomicString& name, bool shouldIgnoreCase) const;
-    size_t findIndex(Attr*) const;
 
 protected:
     size_t findSlowCase(const AtomicString& name, bool shouldIgnoreAttributeCase) const;
 
     ContainerMemberType m_attributes;
 };
 
 class AttributeArray {
     DISALLOW_NEW();
 public:
@@ skipping 95 matching lines @@
 {
     iterator end = this->end();
     for (iterator it = begin(); it != end; ++it) {
         if (it->name().matches(name))
             return it;
     }
     return nullptr;
 }
 
 template <typename Container, typename ContainerMemberType>
-size_t AttributeCollectionGeneric<Container, ContainerMemberType>::findIndex(Attr* attr) const
-{
-    // This relies on the fact that Attr's QualifiedName == the Attribute's name.
-    iterator end = this->end();
-    unsigned index = 0;
-    for (iterator it = begin(); it != end; ++it, ++index) {
-        if (it->name() == attr->qualifiedName())
-            return index;
-    }
-    return kNotFound;
-}
-
-template <typename Container, typename ContainerMemberType>
 size_t AttributeCollectionGeneric<Container, ContainerMemberType>::findSlowCase(const AtomicString& name, bool shouldIgnoreAttributeCase) const
 {
     // Continue to checking case-insensitively and/or full namespaced names if necessary:
     iterator end = this->end();
     unsigned index = 0;
     for (iterator it = begin(); it != end; ++it, ++index) {
         // FIXME: Why check the prefix? Namespace is all that should matter
         // and all HTML/SVG attributes have a null namespace!
         if (!it->name().hasPrefix()) {
             if (shouldIgnoreAttributeCase && equalIgnoringCase(name, it->localName()))
                 return index;
         } else {
             // FIXME: Would be faster to do this comparison without calling toString, which
             // generates a temporary string by concatenation. But this branch is only reached
             // if the attribute name has a prefix, which is rare in HTML.
             if (equalPossiblyIgnoringCase(name, it->name().toString(), shouldIgnoreAttributeCase))
                 return index;
         }
     }
     return kNotFound;
 }
 
 } // namespace blink
 
 #endif // AttributeCollection_h