Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1467143002: [iOS] Remove support for asynchronous pref creation. (Closed)

Created:
5 years, 1 month ago by droger
Modified:
5 years, 1 month ago
Reviewers:
sdefresne
CC:
chromium-reviews, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[iOS] Remove support for asynchronous pref creation Committed: https://crrev.com/6898e58793dc4ed064caaccefeb51ca55d171c95 Cr-Commit-Position: refs/heads/master@{#361093}

Patch Set 1 #

Patch Set 2 : Fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -15 lines) Patch
M ios/chrome/browser/application_context_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/prefs/ios_chrome_pref_service_factory.h View 1 1 chunk +3 lines, -5 lines 0 comments Download
M ios/chrome/browser/prefs/ios_chrome_pref_service_factory.cc View 4 chunks +5 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
droger
5 years, 1 month ago (2015-11-23 10:00:13 UTC) #3
sdefresne
lgtm
5 years, 1 month ago (2015-11-23 10:03:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1467143002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1467143002/20001
5 years, 1 month ago (2015-11-23 12:14:44 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-23 12:18:36 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 12:19:33 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/6898e58793dc4ed064caaccefeb51ca55d171c95
Cr-Commit-Position: refs/heads/master@{#361093}

Powered by Google App Engine
This is Rietveld 408576698