third_party/WebKit/Source/web/tests/FrameTestHelpers.h - Issue 1467123003: Create base class for common functionality of Web{Local,Remote}Frame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/FrameTestHelpers.h

Issue 1467123003: Create base class for common functionality of Web{Local,Remote}Frame (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: --no-find-copies Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/web/WebLocalFrameImpl.cpp ('K') | « third_party/WebKit/Source/web/WebViewImpl.cpp ('k') | third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/tests/FrameTestHelpers.h

diff --git a/third_party/WebKit/Source/web/tests/FrameTestHelpers.h b/third_party/WebKit/Source/web/tests/FrameTestHelpers.h

index 8507f93fe81681d6f996d2852787ace96a49dc6a..dc110adcdf63b4103ff83d2d77371ecdda239054 100644

--- a/third_party/WebKit/Source/web/tests/FrameTestHelpers.h

+++ b/third_party/WebKit/Source/web/tests/FrameTestHelpers.h

@@ -47,6 +47,8 @@

namespace blink {

+class WebRemoteFrameImpl;

namespace FrameTestHelpers {

class TestWebFrameClient;

@@ -150,7 +152,7 @@ class TestWebRemoteFrameClient : public WebRemoteFrameClient {

public:

TestWebRemoteFrameClient();

- WebRemoteFrame* frame() const { return m_frame; }

+ WebRemoteFrameImpl* frame() const { return m_frame; }

dcheng 2015/11/23 09:00:17 I made this return the impl directly, to make it e

// WebRemoteFrameClient overrides:

void frameDetached(DetachType) override;

@@ -161,7 +163,7 @@ public:

WebDOMMessageEvent) override { }

private:

- WebRemoteFrame* const m_frame;

+ WebRemoteFrameImpl* const m_frame;

};

class TestWebViewClient : public WebViewClient {